-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Depreciation message for rmt.h #28
Comments
Hi Klaus, thanks for the report. I'll investigate switching over to the new driver when I move to IDF 5.0. |
On owb_rmt.c file: changing the rmt_set_pin function to rmt_set_gpio and adding a boolean 0 flag as a last parameter works for me. ( it was finding devices but not showing the readings temp, now it works just fine!) |
I also applied that change locally. I was getting crashes when I tried addressing a 1wire device that was no longer connected (testing my error handling) and applying this change fixed these crashes. |
The IDF v5.0.1 build should be ok in As for the |
Thanks for accepting the PR 👍 |
FYI, there is now an example for 1-wire (based on rmt peripheral) on esp-idf itself: |
Ah! Many thanks for that - I'd looked for an Espressif example but couldn't see one |
Update: I’ve read the docs for the new |
@mjcross sure, if it's original code and it continues to work with the esp32-ds18b20 component (single, multiple & parasitic), and the associated example app, I'd be happy to consider merging such a PR. Thank you for offering. It is interesting that Espressif now have their own OWB example, using RMT. The question of whether |
I asked myself the same question about whether |
By the way, when I said a ‘rewrite’ I was only proposing to replace the current owb_rmt.c and .h, leaving everything else the same (well that is the objective, anyhow) :-) |
Yes, the IDF example is probably less useful for integrators as it's designed for teaching, mostly. Anyway, having a choice is good. If you need to use the example to learn how to implement this, by all means, but please do try to keep the new code original. I know that can be difficult when both codebases are practically doing the same thing, but I also don't want to run into licensing issues. To be frank I've never used the parasitic feature beyond writing the support for it, so I actually can't remember! I've just looked through the code and I can't see any indication that it's not designed to work with RMT, but perhaps there is an issue and it hasn't been brought up formally. If you have the ability to test this, please do, but if you can't let me know and I can rig something up and give it a go. Copy that on "rewrite" - I understood you :) Thanks again, I appreciate you taking an interest in this component and being a contributor. Happy to put a credit in the README once done, if you are OK with that. |
Completely agree on the importance of steering clear of licensing issues; and I’m fine with that. I wrote the Pico driver from scratch including the pesky ROM search code, so it’s pretty familiar turf apart from the RMT aspect. |
Shared a private repo with you @DavidAntliff, for the work in progress |
Basic framework done; OWB bus reset and slave detection are now working. |
Everything now seems to work fine so I'll start preparing a PR |
Now works with
Further testing underway, to be on the safe side |
Yes I'm happy with it - in fact I've been using it in production for a few weeks now. |
@mjcross Thanks for the information, the 'esp32_onewire' looks interesting, what is the differences between that and 'esp32-owb' (what would I miss compared to 'esp32-owb')? |
@NRollo You're welcome. They both use exactly the same code to talk to the bus, but If you compare the two examples |
Hi David,
when compiling with idf5.0 (master branch), I get a depreciation message for rmt.h:
esp-idf/components/driver/deprecated/driver/rmt.h:18:2: warning: #warning "The legacy RMT driver is deprecated, please use driver/rmt_tx.h and/or driver/rmt_rx.h" [-Wcpp]
Regards,
Klaus
The text was updated successfully, but these errors were encountered: