Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Break Subclasses of the Abstract Classes Defined in "generics" Directory Out to Separate Files #10

Open
DavidBerdik opened this issue Apr 3, 2022 · 1 comment
Open

Break Subclasses of the Abstract Classes Defined in "generics" Directory Out to Separate Files #10

DavidBerdik opened this issue Apr 3, 2022 · 1 comment
Labels
todo Note about change that should be made in the future

Comments

@DavidBerdik
Copy link
Owner

Currently, all of the subclasses that inherit from the abstract classes defined in the generics directory are all jammed in to the file which contains their abstract class. For example, all of the distance functions are stored in DistanceFunction.py. To keep the PyGAAP code neat, we should break these out in to separate files using the same (or at least, a similar) structure as what JGAAP uses.

@Michaeljfang
@DavidBerdik DavidBerdik added the todo Note about change that should be made in the future label Apr 3, 2022
@AJNapolitanoJawerbaum
Copy link
Collaborator

I'll be working on this issue, while also porting more existing JGAAP functionalities into PyGAAP.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
todo Note about change that should be made in the future
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@DavidBerdik @AJNapolitanoJawerbaum