Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Continue to clean up the poor programming practices from ORB_SLAM3 #5

Open
DavidPetkovsek opened this issue Apr 30, 2023 · 1 comment
Open

Continue to clean up the poor programming practices from ORB_SLAM3 #5

DavidPetkovsek opened this issue Apr 30, 2023 · 1 comment
Labels
bug Something isn't working enhancement New feature or request refactor Rewrite code to be easier to understand

Comments

@DavidPetkovsek
Copy link
Owner

DavidPetkovsek commented Apr 30, 2023 •
edited
Loading

  • Storing pointers of everything
  • Magic numbers
  • Thread management
  • Repeated code
  • Variable names
  • 'Public api'
  • Coupling
  • Public vs private includes

refer to Soldann#54
@DavidPetkovsek DavidPetkovsek added bug Something isn't working enhancement New feature or request refactor Rewrite code to be easier to understand labels Apr 30, 2023
@DavidPetkovsek
Copy link
Owner Author

#16 takes a few big steps in this direction

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working enhancement New feature or request refactor Rewrite code to be easier to understand
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@DavidPetkovsek