Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to Symphonia for audio due to security advisory #60

Closed
Davidster opened this issue Mar 31, 2023 · 2 comments · Fixed by #62
Closed

Switch to Symphonia for audio due to security advisory #60

Davidster opened this issue Mar 31, 2023 · 2 comments · Fixed by #62

Comments

@Davidster
Copy link
Owner

Security advisory: https://github.com/Davidster/ikari/security/dependabot/3
Probably won't be fixed by minimp3 any time soon: germangb/minimp3-rs#38
Alternative library which is more actively maintained: https://github.com/pdeljanov/Symphonia
Someone else also switching to Symphonia: RustAudio/rodio#456 (comment)

@CatCode79
Copy link
Collaborator

I don't know Symphonia to tell the pros and cons, but kira is a good alternative

@Davidster
Copy link
Owner Author

interestingly it seems like kira is using symphonia under the hood: https://github.com/tesselode/kira/blob/main/crates/kira/Cargo.toml.

seems like kira doesn't support 3d audio so I'd rather stick with oddio for the time being

@Davidster Davidster mentioned this issue Apr 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants