Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use MySqlConnectionStringBuilder instead of 'manually' parsing the connection string #5

Open
darraghjones opened this issue Oct 19, 2020 · 1 comment
Labels
bug Something isn't working

Comments

@darraghjones
Copy link

darraghjones commented Oct 19, 2020

I defined my connection string using 'initial catalogue' instead of 'database'. However, this line of code then does not work correctly:
https://github.com/DbUp/DbUp/blob/c8f94a2ff915e651b5b573328e0f01d50d8241c4/src/dbup-mysql/MySqlExtensions.cs#L27

I suggesting using the MySqlConnectionStringBuilder to parse the connection string.

@darraghjones darraghjones added the bug Something isn't working label Oct 19, 2020
@AdrianJSClark
Copy link
Member

I agree, sounds like a great idea.

Happy for you to submit a PR if you have time, @darraghjones. Otherwise someone will have a look as soon as they are free.

@droyad droyad transferred this issue from DbUp/DbUp Jan 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Wishlist
Development

No branches or pull requests

2 participants