Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bundle Native Binary? #10

Closed
1 task done
droyad opened this issue Jul 29, 2024 · 1 comment · Fixed by #11
Closed
1 task done

Bundle Native Binary? #10

droyad opened this issue Jul 29, 2024 · 1 comment · Fixed by #11
Labels
enhancement New feature or request

Comments

@droyad
Copy link
Member

droyad commented Jul 29, 2024 •
edited
Loading

Is there an existing issue for this?

  • I have searched the existing open and closed issues

Description

At the moment this provider references Microsoft.Data.Sqlite which includes the native SQLite libraries.

There is Microsoft.Data.Sqlite.Core which does not.

Should we reference that instead? It would then leave the choice of whether to bundle or not up the the consumer. (PR: #11)

What is the impact?

The native binaries would no longer be bundled.
@droyad droyad added the enhancement New feature or request label Jul 29, 2024
@droyad droyad pinned this issue Jul 29, 2024
@droyad droyad mentioned this issue Jul 29, 2024
Merged
@droyad
Copy link
Member Author

droyad commented Dec 17, 2024

No objections, so :shipit:

@droyad droyad closed this as completed Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Reference SQLite Core package DbUp/dbup-sqlite
1 participant
@droyad