Better parsing of double quoted texts. #374
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jburger or @AdrianJSClark Could you have a quick look at this? From what I can see it shouldn't break anything, but this parser always make me nervous. |
src/dbup-core/Support/SqlParser.cs
Outdated
| @@ -355,6 +364,7 @@ private bool IsEndOfSlashStarComment | |||
| /// </summary> | |||
| private void ReadQuotedString() | |||
| { | |||
| var quoteChar = CurrentChar; | |||
There was a problem hiding this comment.
Suggested change
| var quoteChar = CurrentChar; | |
| var currentQuoteChar = CurrentChar; |
There was a problem hiding this comment.
This variable naming makes more sense to me, especially further down where it is used. YMMV - happy to leave it as-is.
src/dbup-core/Support/SqlParser.cs
Outdated
| @@ -364,7 +374,7 @@ private void ReadQuotedString() | |||
| Read(); | |||
| } | |||
| ReadCharacter(CharacterType.QuotedString, CurrentChar); | |||
| if (IsQuote) | |||
| if (CurrentChar == quoteChar) | |||
There was a problem hiding this comment.
Suggested change
| if (CurrentChar == quoteChar) | |
| if (CurrentChar == currentQuoteChar) |
|
@sgoodgrove Please rebase onto |
sungam3r
added
the
needs confirmation
|
@sungam3r this is not a huge issue for me, but happy to update. |
mjauernig
approved these changes
Oct 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should resolve DbUp/dbup-sqlserver#3 by supporting double quoted strings in the same manner as single quoted strings. It may be that IsDoubleQuote should be a protected member, but that throws out the API tests for changes to the public signature.