Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jellyfish-wallet: Transaction Builder Improvement #635

Open
fuxingloh opened this issue Sep 1, 2021 · 2 comments
Open

jellyfish-wallet: Transaction Builder Improvement #635

fuxingloh opened this issue Sep 1, 2021 · 2 comments
Labels
area/packages kind/feature New feature request needs/triage Waiting for triage to be accepted sig/wallet

Comments

@fuxingloh
Copy link
Contributor

What would you like to be added:

Currently, in @defichain/jellyfish-transaction-builder it creates a transaction and signs the transaction with the provided elliptic pair interface. The idea, novel at the time being an all-inclusive DfTx builder and signer. This proves difficult when implementing upstream on DeFiCh/wallet.

DeFiCh/wallet has a transaction narrative that flows as such:

BirthdayResearch/defichain-wallet#730

  1. Gathering Prevout
  2. Preparing Transaction
  3. Confirming Prepared Transaction
  4. Sign Prepared Transaction
  5. Confirmed Signed Transaction
  6. Broadcast Signed Transaction

These 6 steps belong to a methodical process that requires a few UI to implement. The current implementation, automate 1-4 into a swift action making it hard to follow/engineer a flow in UI.

This issue calls for a redesign/refactors of builder implementation to follow those 6 steps. Each action will have its own function to call upon. Beest implemented on @defichain/jellyfish-wallet on a extension of -*.

@defichain-bot
Copy link
Member

@fuxingloh: Thanks for opening an issue, it is currently awaiting triage.

The triage/accepted label can be added by foundation members by writing /triage accepted in a comment.

Details

I am a bot created to help the DeFiCh developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the DeFiCh/oss-governance-bot repository.

@defichain-bot defichain-bot added the needs/triage Waiting for triage to be accepted label Sep 1, 2021
@defichain-bot defichain-bot added the needs/area Needs area label(s) label Dec 16, 2021
@defichain-bot defichain-bot removed the needs/area Needs area label(s) label Dec 23, 2021
@fuxingloh
Copy link
Contributor Author

Other wallet improvement suggestions:

  • Deterministic Fee Estimation
  • Transaction Queueing
  • Transaction Creation to be written into a modular pattern where it can be tree shaken

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/packages kind/feature New feature request needs/triage Waiting for triage to be accepted sig/wallet
Projects
None yet
Development

No branches or pull requests

2 participants