Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simulation propagation distance being less than step size not caught in validation #48

Open
Tracked by #58
DavidDierickx opened this issue Nov 1, 2022 · 1 comment · May be fixed by #58
Open
Tracked by #58

Simulation propagation distance being less than step size not caught in validation #48

DavidDierickx opened this issue Nov 1, 2022 · 1 comment · May be fixed by #58
Assignees
@patrickcleeve2
Labels
bug Something isn't working

Comments

@DavidDierickx
Copy link
Collaborator

Recreation:
Set propagation distance to 0.5e-6 in Beam Creator
Set step size to 1.e-6 in Simulation Setup
Attempt to generate simulation
@DavidDierickx DavidDierickx added the bug Something isn't working label Nov 1, 2022
@DavidDierickx DavidDierickx mentioned this issue Nov 1, 2022
Closed
patrickcleeve2 pushed a commit that referenced this issue Mar 1, 2023
[BUG] Simulation propagation distance being less than step size not c…
c2fd40f 
…aught in validation #48
@patrickcleeve2
Copy link
Collaborator

image
added check to step size, fixed issue with ui check on step_size, added test for check. in c2fd40f

@patrickcleeve2 patrickcleeve2 linked a pull request Mar 1, 2023 that will close this issue
Open
7 tasks
@patrickcleeve2 patrickcleeve2 reopened this Mar 1, 2023
@patrickcleeve2 patrickcleeve2 linked a pull request Mar 1, 2023 that will close this issue
Release 0.1.0 #58
Open
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@patrickcleeve2 patrickcleeve2

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Release 0.1.0 DeMarcoLab/juno
2 participants
@DavidDierickx @patrickcleeve2