Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

correcting some minor mistakes in IERC comments #62

Open
3 tasks done
dhruvmalik007 opened this issue Sep 22, 2022 · 2 comments
Open
3 tasks done

correcting some minor mistakes in IERC comments #62

dhruvmalik007 opened this issue Sep 22, 2022 · 2 comments
Assignees

Comments

@dhruvmalik007
Copy link
Contributor

dhruvmalik007 commented Sep 22, 2022

Based on the feedback from @yuliu-debond and an anon dev.

steps:

  • review personally the interface and do the changes.
  • get review from @yuliu-debond and ask the different comments.
  • ask @Pandapip1 for the change (with some justification).
@dhruvmalik007 dhruvmalik007 self-assigned this Sep 22, 2022
@dhruvmalik007
Copy link
Contributor Author

@yuliu-debond
the branch that is consisting of the changes are following: Debond-Protocol/EIPs@f3d39dc

if you think more changes are to be done, you can give an approx line which needs to be changes and i will then do PR to EIP.

@dhruvmalik007
Copy link
Contributor Author

@yuliu-debond , Could you tell me what else changes are tbd as there has been PR going on. i will add you also the reviewer

ethereum/EIPs#5742

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant