-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ERC standard for ZK based KYC verification #87
Comments
https://github.com/yuliu-debond/KYC_verifier-/blob/main/EIP/EIP6595.md
|
HI yu, i had some queries regarding the description of the metadata,
|
currently it will be reviewed this afternoon for merge. i have added another diagram along with the updated description |
Following concerns posed by the reviewer during the office hour calls: I think my biggest concern with this EIP as written is that it doesn't provide enough substance for a third party to come along and implement a compatible contract. Some of that information is likely in the Reference Implementation, but the body of the EIP itself doesn't explain enough. Assorted other questions: Why are the requirements published on-chain at all? "What is the value of standardizing this interface instead of each dapp handling it themselves (or put in other words, when are multiple EIP-5851 implementations going to talk to each other)? Why not represent each validated requirement as its own SBT?" |
I will rewrite the standard again as the interface is essentially very specific to our use case and not enough generalized in order to be used it as standard. So I will study the implementation of how sismo does that and then rewrite a reference example that works. meanwhile, it will be better not to rush this proposal unless all of the dev team members do agree on the implementation specs. |
The text was updated successfully, but these errors were encountered: