Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unmarking students using s/all in unmark command #3

Open
Decaxical opened this issue Apr 16, 2022 · 1 comment
Open

Unmarking students using s/all in unmark command #3

Decaxical opened this issue Apr 16, 2022 · 1 comment

Comments

@Decaxical
Copy link
Owner

Decaxical commented Apr 16, 2022

UG states that "unmark c/1 w/3 s/all unmarks the attendances of all the students belonging to the 1st
class group for week 3"

image.png

However when using s/all,

image.png

TAssist attempts to unmark ALL students even those that are not part of the group

@soc-se-bot
Copy link

soc-se-bot commented Apr 19, 2022

Team's Response

The command works as intended in marking/unmarking the attendances of all the students belonging to the 1st class group for week 3. Also, it is stated that when all parameter is used, we will include all students. The following line is lifted from our UG under unmark attendance: Students may be specified with either all (i.e. all students), STUDENT_INDEXES or STUDENT_IDS.

Items for the Tester to Verify

❓ Issue response

Team chose [response.Rejected]

  • I disagree

Reason for disagreement: The team claims that the UG states: Students may be specified with either all (i.e. all students), STUDENT_INDEXES or STUDENT_IDS. There is no specification if it means all students within TAssist or all students within the class specified. It is also unlikely a reader would interpret this as all students within TAssist especially since a class must be specified. As the example in the UG states:

image.png

This image was also included in my initial bug report. The example states that it only unmarks all students belonging to the class specified hence it is reasonable to interpret that "all students" in Students may be specified with either all (i.e. all students), STUDENT_INDEXES or STUDENT_IDS refers to all students within the class and NOT all students within TAssist.

  1. If the team considers this a type.DocumentationBug I believe that it is still worthy of a severity.Medium as the documentation in the UG is VERY misleading and is not clear of what the intended behaviour should be for the reasons stated above.

  2. If the team considers this the intended behaviour of unmarking all students within TAssist. Then I believe that this is a severity.Medium type.FeatureFlaw in addition to a type.DocumentationBug as there should be no reason why unmark attempts to unmark ALL students within TAssist rather than just unmarking the students within the class specified which is a critical design flaw.

I admit that it is my mistake for thinking it is a type.FunctionalityBug as I had thought the team was only trying to unmark all students within the class rather than ALL students in TAssist.


❓ Issue severity

Team chose [severity.Low]
Originally [severity.Medium]

  • I disagree

Reason for disagreement: I disagree that this bug should be considered as low since it is stated that severity.Low bugs are unlikely to affect normal usage of the product, only happen in very rare situations and cause a minor inconvenience only.

image.png

I believe that users will use this function often and that the inconvenience and confusion caused are substantial as there should be no reason why the app attempts to unmark students that are not relevant.

Since this is the intended functionality of the feature, I would say that this should be a severity.Medium FeatureFlaw as there should be no reason why all students are unmarked when only the students in the class should be unmarked.


Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants