Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bmake check does not seem to work properly #11

Open
fblanqui opened this issue Apr 17, 2023 · 5 comments
Open

bmake check does not seem to work properly #11

fblanqui opened this issue Apr 17, 2023 · 5 comments

Comments

@fblanqui
Copy link
Member

bmake check ends instantaneously: it does seem to do anything.
Moreover, nubo seems to use dkcheck instead of dk check.

@gabrielhdt
Copy link
Member

In which directory did you run bmake check?

@gabrielhdt
Copy link
Member

For the dkcheck v dk check, indeed you're right, it can be seen there

CHECK ?= dkcheck 2> /dev/null

Probably we'd like the program to check the version of the tools that are used (for better reproducibility).

@fblanqui
Copy link
Member Author

19:21 ~/src/nubo/libraries/arith_fermat/sttfa,1.0 (master) bmake download
===> Downloading
######################################################################### 100,0%
OK
===> Unpacking
OK
19:21 ~/src/nubo/libraries/arith_fermat/sttfa,1.0 (master) time bmake check
===> Proof checking
OK

real	0m0,404s
user	0m0,354s
sys	0m0,050s
19:21 ~/src/nubo/libraries/arith_fermat/sttfa,1.0 (master) ls
arith_fermat-1.0-sttfa/  arith_fermat-1.0-sttfa.tgz  Makefile
19:21 ~/src/nubo/libraries/arith_fermat/sttfa,1.0 (master) ls arith_fermat-1.0-sttfa
bigops.dk  connectives.dk  fact.dk    leibniz.dk  permutation.dk  sigma_pi.dk
bool.dk    div_mod.dk      fermat.dk  logic.dk    primes.dk
cong.dk    exp.dk          gcd.dk     nat.dk      relations.dk

There is no dko files.

@gabrielhdt
Copy link
Member

IIRC, dko files are stored in the cache directory, which ought to be the directory _cache. This is defined at

CACHE ?= ${NUBOROOT}/_cache

So normally, the dkos should be in ~/src/nubo/_cache (what does find ~/src/nubo/_cache -name '*.dko' say?)

@fblanqui
Copy link
Member Author

I see. Thank you Gabriel. Could you please document this and update the dk checker name?
I am also wondering if it wouldn't be better to be more verbose on what's happening, for instance by printing the names of checked files?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants