Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aragon Vote Rewards JSON #3

Open
DeepDAO2 opened this issue Oct 23, 2021 · 9 comments
Open

Aragon Vote Rewards JSON #3

DeepDAO2 opened this issue Oct 23, 2021 · 9 comments

Comments

@DeepDAO2
Copy link

Rewards Object

The current version of Aragon Connect doesn't specify the proposal rewards in a detailed format that can be parsed by code. For this bounty please create a vote_rewards JSON, as specified in the technical requirements below.

Technical Requirements
The Rewards JSON will include the specifics of each token, and token value requested as part of the Vote.

  • For example if the person creating the Vote requests 1000 ANT and 500 USDC. The Rewards JSON object will specify each token's address, symbol, and monetary value. 

  • If the Vote is for the execution of code and not directly a monetary reward, the Rewards JSON would specify the contract address, and function name. 

  • If the Vote doesn't directly ask for a monetary reward, or the execution of code, the Rewards object will be null. 

A fully realized submission will apply for all existing, and future Votes on Aragon V1. A minimal implementation will include only rewards on future Votes.

Submission
Provide a PR on the Connect Github with the fix.

Judging Criteria
The judges are members of the DeepDAO and Aragon technical teams.

DeepDAO
Website
Discord
Twitter

@gitcoinbot
Copy link

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


This issue now has a funding of 2500.0 USDC (2500000000000000.0 USD @ $1.0/USDC) attached to it.

@blockchain-nz
Copy link

Could you define "Rewards JSON" please?
Do you want to create another package like "connnet-voting"?
https://github.com/aragon/connect/tree/4475d1551d46bee617b048876242cfa049f6617d/packages/connect-voting
Or do you want to create a JSON file with required content like "Voting.json"?
https://github.com/aragon/connect/blob/4475d1551d46bee617b048876242cfa049f6617d/packages/connect-voting/subgraph/abis/Voting.json

Thanks!

@githubdoramon
Copy link

@blockchain-nz it should be an extra json property in the already existing connect-voting

@gitcoinbot
Copy link

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


Workers have applied to start work.

These users each claimed they can complete the work by 2 days, 7 hours from now.
Please review their action plans below:

1) pmlambert has applied to start work (Funders only: approve worker | reject worker).

DAO Global Hackathon Contribution

Learn more on the Gitcoin Issue Details page.

@FrGS-0
Copy link

FrGS-0 commented Nov 11, 2021

Hi.
I was reading through the source code and the documentation and I have a few questions. This bounty is about improving the Vote class at https://github.com/aragon/connect/blob/master/packages/connect-voting/src/models/Vote.ts, right? Do I need to add a new property like originalCreator and yea? Does this new property need to be provided by the creator when the class is instantiated or it has to be calculated some other way (Parsing the code in the script property, for example)? If so, I think I can fix the problem simply by adding a few more lines of code and some validation.

@PJColombo
Copy link

PJColombo commented Nov 12, 2021

Hello @DeepDAO2 and @githubdoramon!

I just posted a PR addressing this issue.

@pmlambert
Copy link

pmlambert commented Nov 18, 2021

@DeepDAO2 @githubdoramon
aragon/connect#337

https://thegraph.com/hosted-service/subgraph/pmlambert/aragon-voting?selected=playground

It has queries directly for script executions and rewards for all votes, or listing them by vote.

@gitcoinbot
Copy link

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


Work for 2500.0 USDC (2500.00 USD @ $1.0/USDC) has been submitted by:


Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants