Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor StructureSimilarity #86

Open
NicoRenaud opened this issue Oct 3, 2022 · 2 comments
Open

Refactor StructureSimilarity #86

NicoRenaud opened this issue Oct 3, 2022 · 2 comments
Labels

Comments

@NicoRenaud
Copy link
Member

StructureSimilarity is a bit of a mess now. We have different ways of computing the metrics and they don't all have the same features and internal checks :

  • Some routines check for residue and atom matching some don't
  • Some routines accept multiple chains some don't

We want a unified API for all metrics such as :

def compute_x(self, chain_pairs=None, xzone=None, method='svd', check=True, name=['CA','C','N','O'] ):
@github-actions
Copy link

github-actions bot commented Nov 4, 2022

This issue is stale because it has been open for 30 days with no activity. Remove stale label or comment or this will be closed in 7 days.

@github-actions github-actions bot added the stale label Nov 4, 2022
@cbaakman
Copy link

cbaakman commented May 2, 2024

I would like to have the option to select the chain IDs in.

def compute_lrmsd_pdb2sql(self, exportpath=None, method='svd', **kwargs):

Right now, it always picks the first two.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants