Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default background color should be "No Fill" #102

Open
jnothman opened this issue Jun 8, 2021 · 3 comments
Open

Default background color should be "No Fill" #102

jnothman opened this issue Jun 8, 2021 · 3 comments

Comments

@jnothman
Copy link

jnothman commented Jun 8, 2021

Currently the background colour for cells defaults to white, per:

self.bg_color = get_color_from_string(bg_color, default_color=utils.colors.white)

I think the default background colour should be No Fill.

This is important when, for instance, the user adds a Table to the spreadsheet. Its banding won't appear if the cell background is white.

@DeepSpace2
Copy link
Owner

Maybe related to #42.

I think this is not about the default value of Styler.bg_color, but of Styler.fill_patern_type, right?

@jnothman
Copy link
Author

Probably Styler.fill_patern_type; I'm no expert on openxml

@stale
Copy link

stale bot commented Aug 13, 2021

This issue has been automatically marked as stale because it has not had activity in the last 60 days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants