Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 10401 enhanced naming of discovered findings filter and add same for mitigated #10402

Conversation

quirinziessler
Copy link
Contributor

fixes #10401 and adds same functionality for mitigated.
image

Copy link

dryrunsecurity bot commented Jun 14, 2024

Hi there 👋, @DryRunSecurity here, below is a summary of our analysis and findings.

DryRun Security Status Findings
Server-Side Request Forgery Analyzer 0 findings
IDOR Analyzer 0 findings
Sensitive Files Analyzer 2 findings
SQL Injection Analyzer 0 findings
Configured Codepaths Analyzer 2 findings
Authn/Authz Analyzer 0 findings
Secrets Analyzer 0 findings

Note

🔴 Risk threshold exceeded. Adding a reviewer if one is configured in .dryrunsecurity.yaml.

notification list: @mtesauro @grendel513

Change Summary (click to expand)

The following is a summary of changes in this pull request made by me, your security buddy 🤖. Note that this summary is auto-generated and not meant to be a definitive list of security issues but rather a helpful summary from a security perspective.

Summary:

The code changes in this pull request cover a wide range of updates and improvements to the DefectDojo application, with a focus on enhancing the security and reliability of the application. The changes include updates to various components, such as the Helm chart, Docker build and deployment, notification handling, filtering functionality, and the REST API.

From a security perspective, the key changes include:

  1. Improved Dependency Management: The updates to the Helm chart, Docker build-push action, and Python dependencies ensure that the application is using the latest versions of its dependencies, which often include security fixes and improvements.

  2. Secure Notification Handling: The changes to the notification handling functionality aim to improve the security and flexibility of the notification system, including the ability to target specific recipients and properly sanitize user-provided data.

  3. Robust Filtering and Querying: The updates to the filtering and querying functionality, including the introduction of various filter classes, help ensure that the application can effectively manage and analyze security-related data without introducing vulnerabilities.

  4. Comprehensive REST API Testing: The significant improvements to the REST API test suite, including the addition of permission-based tests and schema validation, help ensure the security and reliability of the API, which is a critical component of the application.

Overall, the changes in this pull request demonstrate a strong focus on maintaining the security and integrity of the DefectDojo application, which is an important tool for security professionals. The updates to dependencies, security-related functionality, and test coverage are all positive steps towards ensuring the ongoing security of the application.

Files Changed:

  • .github/ISSUE_TEMPLATE/bug_report.md: Updated the link to the OWASP Slack workspace.
  • .github/workflows/release-x-manual-docker-containers.yml: Updated the Docker build-push-action from version 5 to version 6, improving the build process and dependency management.
  • docs/package-lock.json: Updated the braces and fill-range dependencies to their latest versions.
  • .github/workflows/build-docker-images-for-testing.yml: Updated the Docker build-push-action from version 5 to version 6 and improved the build process.
  • .github/workflows/integration-tests.yml: Updated the database profile used in the integration tests and improved the phased startup process.
  • dojo/settings/.settings.dist.py.sha256sum: Updated the SHA-256 hash of the .settings.dist.py configuration file.
  • dojo/templates/issue-trackers/jira_full/jira-finding-group-description.tpl: Updated the URLs used in the Jira finding group description template.
  • dojo/notifications/helper.py: Updated the create_notification() function to handle targeted notifications and improved the string formatting.
  • dojo/filters.py: Introduced several new filter classes to improve the filtering and sorting functionality.
  • dojo/settings/settings.dist.py: Updated the Trivy Operator Scan and Trivy Scan parsers to include the description field in the hash_code calculation.
  • dojo/templates/issue-trackers/jira_limited/jira-finding-group-description.tpl: Updated the URLs used in the Jira finding group description template.
  • helm/defectdojo/Chart.lock: Updated the versions of the postgresql, rabbitmq, and redis Helm chart dependencies.
  • dojo/tools/acunetix/parse_acunetix360_json.py: Improved the handling of the Classification field in the Acunetix JSON data.
  • helm/defectdojo/values.yaml: Updated the version of the gce-proxy image used in the cloudsql section.
  • requirements-lint.txt: Updated the ruff Python package from version 0.4.8 to 0.4.9.
  • helm/defectdojo/Chart.yaml: Updated the version of the Helm chart from 1.6.135-dev to 1.6.136-dev.
  • unittests/scans/acunetix/issue_10370.json: Provided a test case for a security vulnerability identified by the Acunetix360 scanner.
  • requirements.txt: Updated the versions of several Python dependencies, including Django, Django-Filter, and Redis.
  • unittests/test_remote_user.py: Added tests

Powered by DryRun Security

@quirinziessler quirinziessler changed the base branch from master to dev June 14, 2024 08:14
@quirinziessler
Copy link
Contributor Author

quirinziessler commented Jun 14, 2024

If there is some comment on #10401 I would also style the discovered filter the same way as I did with mitigated. This would mean 2 filters less on the already imo overfilled filters menu.

@quirinziessler quirinziessler changed the title Fix 10401 update findings filter Fix 10401 discovered findings filter and add same for mitigated Jun 14, 2024
@quirinziessler quirinziessler changed the title Fix 10401 discovered findings filter and add same for mitigated Fix 10401 enhanced naming of discovered findings filter and add same for mitigated Jun 19, 2024
@github-actions github-actions bot added settings_changes Needs changes to settings.py based on changes in settings.dist.py included in this PR docs unittests ui parser helm labels Jun 19, 2024
@quirinziessler
Copy link
Contributor Author

closing because of wrong rebasing

@quirinziessler quirinziessler deleted the fix-10401-update-findings-filter branch June 19, 2024 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs helm parser settings_changes Needs changes to settings.py based on changes in settings.dist.py included in this PR ui unittests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Duplicates in Finding filters
1 participant