Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reimport causes of closing active and valid findings, that still present in scan results #11470

Open
1 task done
paraddise opened this issue Dec 25, 2024 · 1 comment
Open
1 task done
Labels

Comments

@paraddise
Copy link
Contributor

paraddise commented Dec 25, 2024

Bug description
When you import semgrep results as SARIF test type all results saved as needed and you have 34 findings.
But when you try to reimport the same results with option close_old_findings=true, DD marks almost all findings as mitigated and you have 1 active and 33 mitigated.

Steps to reproduce
Steps to reproduce the behavior:

  1. Create Product
  2. Create CI/CD engagement with deduplication disabled
  3. Create test with type SARIF and upload semgrep.sarif
  4. Reimport again semgrep.sarif
  5. Now yoy have 1 active and 33 mitigated results

Expected behavior
When you reimport the same file several times it should produce the same results as in the first import.

Deployment method (select with an X)

  • Kubernetes

Environment information

  • DefectDojo version (see footer) or commit message: 2.41.2

Sample scan files
I can't upload .sarif file, so just remove .json from filename
semgrep.sarif.json

Additional context
I managed to reproduce this bug on demo.defectdojo.org so you can find it here
Async and sync import produce the same results.

@valentijnscholten
Copy link
Member

@paulOsinski I think this one can be closed as duplicate of #11480 as it's a semgrep specific problem described in more detail there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants