Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Patch/csv parsers various message types #527

Merged
merged 4 commits into from
Jan 28, 2024
Merged

Patch/csv parsers various message types #527

merged 4 commits into from
Jan 28, 2024

Conversation

pharr117
Copy link
Collaborator

Does the following:

  1. Removes a hack from parsing group interface to return it to a general implementation
  2. Reworks LP parsing groups to define interface in each subparser
  3. Adds concentrated liquidity position handling parsing group to CSV

@pharr117
Fix csv parsing group interface definition:
9d1cf8e 
1. Remove hack for parserfunc that was using specific subwrapper parsing func signature
2. Redefine parsing group struct definitions in each csv parser subtype
3. Add parsing group in accointing for concentrated liquidity position messages
@pharr117
Add cl position group handling for cointracker
97d2089
@pharr117
Merge branch 'main' into patch/csv-parsers-various-message-types
f01400f
@pharr117
Finish implementation of all parsing groups for cl position handling …
aa1bb43 
…messages
@danbryan danbryan merged commit 94645eb into main Jan 28, 2024
4 checks passed
@danbryan danbryan deleted the patch/csv-parsers-various-message-types branch January 28, 2024 19:00
@pharr117 pharr117 mentioned this pull request Sep 24, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danbryan danbryan Awaiting requested review from danbryan

Assignees
No one assigned
Labels
grant OGP2024
Projects
Defiant OSS
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pharr117 @danbryan