Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sound effects may play for players in lobby during post-round #1767

Open
pissdemon opened this issue Sep 7, 2024 · 1 comment
Open

Sound effects may play for players in lobby during post-round #1767

pissdemon opened this issue Sep 7, 2024 · 1 comment
Labels
Changes: Audio Changes any audio files Priority: 5-Whenever Doesn't matter when this gets resolved Upstream Issue Would probably be solved with an Upstream PR, doesn't mean you can't fix it here.

Comments

@pissdemon
Copy link
Contributor

pissdemon commented Sep 7, 2024

Description

You can sometimes hear sound effects or snippets of sound effects, all of which are non-global (e.g. satchel opening or closing), when you are in the lobby of a post-round game. You should not be able to hear those since you are in the lobby and they are not global sounds. (Certain global sounds playing in the lobby like weather sounds is also an issue, but a separate one from this.)

Reproduction

  1. Be connected and in the lobby, do not join
  2. Wait until a round ends
  3. You may hear some sound effects (but notably, not ALL of them, and they can sound "cut off")

Additional context
Probably an upstream issue, but filing here since I haven't gotten around to check. Maybe related to game state, since I think post-round is a separate game state, maybe there is an issue in audio code with how lobby players are handled post-round vs in-round.

@ghost ghost added Priority: 5-Whenever Doesn't matter when this gets resolved Changes: Audio Changes any audio files and removed Status: Untriaged labels Sep 17, 2024
@ghost
Copy link

ghost commented Sep 17, 2024

As far as I know this is an upstream issue because this also happens everywhere I go - Goob, Frontier, what have you. If someone's running an event with weather it escapes and goes to the lobby (seperate issue.) You hear the flare sound at roundend. Probably involves audio code in some sense, doubt it's local to here.

@ghost ghost added the Upstream Issue Would probably be solved with an Upstream PR, doesn't mean you can't fix it here. label Sep 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: Audio Changes any audio files Priority: 5-Whenever Doesn't matter when this gets resolved Upstream Issue Would probably be solved with an Upstream PR, doesn't mean you can't fix it here.
Projects
None yet
Development

No branches or pull requests

1 participant