Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Several console commands throw errors. #2080

Open
ewokswagger opened this issue Oct 31, 2024 · 4 comments
Open

Several console commands throw errors. #2080

ewokswagger opened this issue Oct 31, 2024 · 4 comments
Labels
Upstream Issue Would probably be solved with an Upstream PR, doesn't mean you can't fix it here.

Comments

@ewokswagger
Copy link
Contributor

ewokswagger commented Oct 31, 2024

Description

Several console commands throw errors including stationevent:lsprob, stations:rename, stations:largestgrid, stationevent:prob, stationevent:simulate, stationevent:lsprobtime.

Reproduction
run stationevent:lsprob

Screenshots

[INFO] CON: > stationevent:lsprob
[INFO] CON: stationevent:lsprob

The type EntityPrototype has no parser available and cannot be parsed.
Please contact a programmer with this error, they'd probably like to see it.
THIS IS A BUG.
   at Robust.Shared.Toolshed.ToolshedCommandImplementor.TryParseArguments(Boolean doAutocomplete, ParserContext parserContext, String subCommand, Type pipedType, Dictionary`2& args, Type[]& resolvedTypeArguments, IConError& error, Nullable`1& autocomplete)
   at Robust.Shared.Toolshed.ToolshedCommand.TryParseArguments(Boolean doAutocomplete, ParserContext parserContext, Type pipedType, String subCommand, Dictionary`2& args, Type[]& resolvedTypeArguments, IConError& error, Nullable`1& autocomplete)
   at Robust.Shared.Toolshed.Syntax.ParsedCommand.TryParseCommand(Boolean makeCompletions, ParserContext parserContext, CommandArgumentBundle bundle, Type pipedType, Type targetType, String& subCommand, Func`2& invocable, ToolshedCommand& command, IConError& error, Boolean& noCommand, Nullable`1& autocomplete)
   at Robust.Shared.Toolshed.Syntax.ParsedCommand.TryParse(Boolean doAutoComplete, ParserContext parserContext, Type pipedArgumentType, ParsedCommand& result, IConError& error, Boolean& noCommand, Nullable`1& autocomplete, Type targetType)
   at Robust.Shared.Toolshed.Syntax.CommandRun.TryParse(Boolean doAutocomplete, ParserContext parserContext, Type pipedType, Type targetOutput, Boolean once, CommandRun& expr, Nullable`1& autocomplete, IConError& error)
   at Robust.Shared.Toolshed.ToolshedManager.InvokeCommand(IInvocationContext ctx, String command, Object input, Object& result)
   at Robust.Shared.Toolshed.ToolshedManager.InvokeCommand(IConsoleShell session, String command, Object input, Object& result, IInvocationContext& ctx)
   at Robust.Server.Console.ServerConsoleHost.ExecuteInShell(IConsoleShell shell, String command)
   at Robust.Server.Console.ServerConsoleHost.ExecuteCommand(ICommonSession session, String command)
   at Robust.Server.Console.ServerConsoleHost.ProcessCommand(MsgConCmd message)
   at Robust.Shared.Network.NetManager.<>c__DisplayClass109_0`1.<RegisterNetMessage>b__0(NetMessage msg)
   at Robust.Shared.Network.NetManager.DispatchNetMessage(NetIncomingMessage msg)
   at Robust.Shared.Network.NetManager.ProcessPackets()
   at Robust.Server.BaseServer.Input(FrameEventArgs args)
   at Robust.Server.BaseServer.<SetupMainLoop>b__67_0(Object sender, FrameEventArgs args)
   at Robust.Shared.Timing.GameLoop.Run()
   at Robust.Server.BaseServer.MainLoop()
   at Robust.Server.Program.ParsedMain(CommandLineArgs args, Boolean contentStart, ServerOptions options)
   at Robust.Server.Program.Start(String[] args, ServerOptions options, Boolean contentStart)
   at Robust.Server.ContentStart.Start(String[] args)
   at Content.Server.Program.Main(String[] args)

[INFO] CON: Failed to execute toolshed command
[INFO] CON:

Additional context
I am running this on a fork updated to the most recent version and updated submodules with RUNTHIS.py and made no other changes.

@deltanedas deltanedas added Upstream Issue Would probably be solved with an Upstream PR, doesn't mean you can't fix it here. and removed Status: Untriaged labels Oct 31, 2024
@deltanedas
Copy link
Member

they are meant to use EntProtoId not EntityPrototype (that would be trying to read an actual prototypes components etc from the command which is bad)
present upstream

@MilonPL
Copy link
Contributor

MilonPL commented Oct 31, 2024

the last time i tried updating a command to use protoid it's been left with no comments for 2 months (and counting)

@deltanedas
Copy link
Member

classic

@ewokswagger
Copy link
Contributor Author

apparently a pr was made for this upstream but is left open space-wizards/space-station-14#32200

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Upstream Issue Would probably be solved with an Upstream PR, doesn't mean you can't fix it here.
Projects
None yet
Development

No branches or pull requests

3 participants