Gridedit 2042 Compute illegal cells polygon when constructing mesh2d with face-node connectivity

[BillSenior]

No description provided.

[Copilot]

Pull Request Overview

This PR implements the computation of illegal cell polygons when constructing a Mesh2D with face-node connectivity. The main change updates the mesh administration logic to identify and store polygons representing holes or invalid cells in the mesh during construction.

Key changes:

• Modified ComputeInnerBoundaryPolygons to identify illegal cells by checking if face mass centers lie within boundary polygons
• Updated IsPointInPolygonNodes function signatures to accept std::span<const Point> instead of std::vector<Point> for better performance and flexibility
• Enhanced BoundingBox class with new constructors and methods supporting std::span

Reviewed Changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
libs/MeshKernel/tests/src/MeshRefinementTests.cpp	Added new test case verifying illegal cell polygon computation and fixed loop variable in existing test
libs/MeshKernel/src/Mesh2D.cpp	Modified boundary walking algorithm to detect and store illegal cells based on face mass center containment
libs/MeshKernel/src/Operations.cpp	Changed polygon node parameters from std::vector to std::span and added required includes
libs/MeshKernel/include/MeshKernel/Operations.hpp	Updated function signatures to use std::span<const Point>
libs/MeshKernel/include/MeshKernel/Mesh2D.hpp	Added illegalCells parameter to WalkMultiBoundaryFromNode method
libs/MeshKernel/include/MeshKernel/BoundingBox.hpp	Added std::span support with new constructors, reset methods, and non-const accessor overloads

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.