Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add generic model utilities and validators (from Ribasim-NL) #1739

Open
evetion opened this issue Aug 20, 2024 · 1 comment
Open

Add generic model utilities and validators (from Ribasim-NL) #1739

evetion opened this issue Aug 20, 2024 · 1 comment
Labels
needs-refinement Issues that are too large and need refinement validation Related to model validation

Comments

@evetion
Copy link
Member

evetion commented Aug 20, 2024

To be downstreamed from Deltares/Ribasim-NL#129

  • remove_node remove a node, possibility to remove connected_edges as well
  • remove_edge: remove an edge, possibility to remove disconnected_nodes as well
  • reverse_edge: reverse an edge and it's from and to properties

I'd also copy (via templating ideally) some validation from Julia to Python:

  • Allowed node neighbors
  • Number of neighbors

Some more validation on geometries

  • Edge geometry requires begin/end to match with nodes
  • Basin/area geometry requires to intersect with the basin node

Furthermore I can imagine we error on creating, and on writing, but allow for reading a model into memory, but give a warning?

@github-project-automation github-project-automation bot moved this to To do in Ribasim Aug 20, 2024
@evetion evetion added the validation Related to model validation label Aug 22, 2024
@SnippenE SnippenE added the needs-refinement Issues that are too large and need refinement label Dec 10, 2024
@visr
Copy link
Member

visr commented Dec 20, 2024

Also running a model is a candidate for this. run_model.py contains a version that makes some assumptions on the model being written, ribasim being in the path etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-refinement Issues that are too large and need refinement validation Related to model validation
Projects
Status: To do
Development

No branches or pull requests

3 participants