Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase portability of testbank (follow-up) #1109

Open
veenstrajelmer opened this issue Feb 4, 2025 · 0 comments
Open

Increase portability of testbank (follow-up) #1109

veenstrajelmer opened this issue Feb 4, 2025 · 0 comments

Comments

@veenstrajelmer
Copy link
Collaborator

veenstrajelmer commented Feb 4, 2025

Codecov was significantly increased in #447 already. Some requireslocaldata testcases are still left though. Prevent p-drive links in unit/systemtests of testbank to increase github codecov.

Check coverage when running pytest -m "not acceptance" --cov=dfm_tools (includes requireslocaldata) locally, compare to coverage on github py312 test.

The requireslocaldata testcases are:

  • test_examples.py::test_run_examples: all p-drive datasets used in example files (this is not really an issue anymore since the test coverage is quite high these days
  • test_get_nc_helpers.py::test_rename_fouvars_tidal: 'p:\1230882-emodnet_hrsm\GTSMv3.0EMODnet\EMOD_MichaelTUM_yearcomponents\GTSMv4.1_yeartide_2014_2.20.06\output\gtsm_model_0000_fou.nc'
  • test_interpolate_grid2bnd.py::test_plipointsDataset_fews_accepted: r'p:\dflowfm\maintenance\JIRA\06000-06999\06187\C01\salinity_DCSM-FM_OB_all.nc'
  • test_interpolate_grid2bnd.py::test_interpolate_tide_to_plipoints: several tidal datasets on P-drive
  • test_observations.py: all gesla3 tests are skipped on github
  • test_xugrid_helpers.py::test_open_dataset_curvilinear: r'P:\archivedprojects\11206304-futuremares-rawdata-preps\data\CMIP6_BC\CMCC-ESM2\vo_Omon_CMCC-ESM2_historical_r1i1p1f1_gn_*.nc'
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant