Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added codecov to tests #1092

Open
wants to merge 11 commits into
base: main
Choose a base branch
from
Open

added codecov to tests #1092

wants to merge 11 commits into from

Conversation

veenstrajelmer
Copy link
Collaborator

@veenstrajelmer veenstrajelmer commented Oct 21, 2024

Issue addressed

Fixes #1077

Explanation

I have added the codecov action to one of the tests.yml workflow. The code coverage now succesfully shows here and will also be updated continuously after this PR is merged: https://app.codecov.io/gh/Deltares/hydromt/tree/fix-codecov.

General Checklist

  • Updated tests or added new tests >> sort of, updated workflow file
  • Branch is up to date with main
  • Tests & pre-commit hooks pass
  • Updated documentation >> not relevant
  • Updated changelog.rst >> not relevant

Data/Catalog checklist

  • data/catalogs/predefined_catalogs.yml has not been modified.
  • None of the old data_catalog.yml files have been chagned
  • data/chagnelog.rst has been updated
  • new file uses LF line endings (done automatically if you used update_versions.py)
  • New file has been tested locally
  • Tests have been added using the new file in the test suite

@veenstrajelmer veenstrajelmer changed the title added codecov to pip pytest added codecov to tests Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Codecov is not being updated
1 participant