-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
replace placeholders with extended variant concept in DataCatalog
#965
Comments
Suggested yaml: my_nice_source:
data_type: DataFrame # not editable by variants
...
variant_keys:
- metadata.provider
- metadata.crs
- driver.filesystem
variants:
- uri: s3://bucket/key1/key2.json # required for all variants.
metadata:
crs: 4326
provider: organisation1
driver:
filesystem: s3
- uri: /mnt/p/cooldata.json
metadata:
crs: 90002
provider: organization2
driver:
filesystem: local
default_variant: True Where |
Also discussed: DataCatalog._sources should become a dictionary of lists with all variants (instead of a nested dict currently) where we find the requested variant based on filtering. To request a specific variant a dictionary with source name and variant keys and associated values is given to the da = data_catalog.get_rasterdataset(
data_like = {"source": "my_nice_source", "metadata.crs": 4326},
...
) In addition to the yaml format above which specifies my_nice_source:
variant_keys:
- name
variants:
- uri: s3://bucket/key1/key2.json
variant:
name: key2
- uri: /mnt/p/cooldata.json
variant:
name: cooldata |
DataCatalog
DataCatalog
@hboisgon We would like to also get your feedback on this issue. With this new variant concept I think we have a single (before we had variant, alias and placeholder), but flexible way to define multiple variants of the same source. For the cmip6 model archive it would require a longer catalog yaml file, but with more flexibility to accommodate small differences between files in terms of format. |
Kind of request
Changing existing functionality
Enhancement Description
Use case
We should discuss if we want to merge these concept to have a simpler interface for users
Additional Context
No response
The text was updated successfully, but these errors were encountered: