Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bugs in setup_link1d2d #132

Closed
2 tasks done
shartgring opened this issue Aug 6, 2024 · 0 comments · Fixed by #133
Closed
2 tasks done

bugs in setup_link1d2d #132

shartgring opened this issue Aug 6, 2024 · 0 comments · Fixed by #133
Assignees
@shartgring
Labels
bug Something isn't working

Comments

@shartgring
Copy link
Collaborator

Version checks

  • I have checked that this issue has not already been reported.
  • I have checked that this bug exists on the latest version.

Reproducible Example

Running the model builder results in failures due to some bugs when link_direction is 2d1d. It has to do with the variable types in some of the code (GeometryList related mostly), not with the functionality itself

Current behaviour

Running setup_link1d2d with direction 2d1d will always fail

Desired behaviour

setup_link1d2d with direction 2d1d should be able to run

Additional context

No response
@shartgring shartgring added the bug Something isn't working label Aug 6, 2024
@shartgring shartgring self-assigned this Aug 6, 2024
@shartgring shartgring mentioned this issue Aug 6, 2024
Merged
5 tasks
@veenstrajelmer veenstrajelmer linked a pull request Sep 25, 2024 that will close this issue
Bugfix setup channels and 2d1d links #133
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@shartgring shartgring

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Bugfix setup channels and 2d1d links Deltares/hydromt_delft3dfm
1 participant
@shartgring