Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for python 3.12 #136

Closed
veenstrajelmer opened this issue Sep 20, 2024 · 0 comments · Fixed by #149
Closed

Add support for python 3.12 #136

veenstrajelmer opened this issue Sep 20, 2024 · 0 comments · Fixed by #149
Labels
enhancement New feature or request

Comments

@veenstrajelmer
Copy link
Collaborator

veenstrajelmer commented Sep 20, 2024

Kind of request

None

Enhancement Description

With a local (pip) installation of hydromt_delft3dfm@fix-tests, the testbank runs without issues on python 3.12. But on github the installation of the env somehow fails:
image

This happens because hydromt 0.10.0 does not support python 3.12 according to conda:

  LibMambaUnsatisfiableError: Encountered problems while solving:
    - nothing provides _python_rc needed by python-3.12.0rc3-rc3_h2628c8c_1_cpython
  
  Could not solve for environment specs
  The following packages are incompatible
  \u251c\u2500 hydromt >=0.10.0,<0.15  is installable and it requires
  \u2502  \u2514\u2500 python >=3.9,<3.12  with the potential options
  \u2502     \u251c\u2500 python [3.10.0|3.10.1|...|3.9.9], which can be installed;
  \u2502     \u2514\u2500 python 3.12.0rc3 would require
  \u2502        \u2514\u2500 _python_rc, which does not exist (perhaps a missing channel);
  \u2514\u2500 python 3.12.*,>=3.9  is not installable because there are no viable options
     \u251c\u2500 python 3.12.0rc3, which cannot be installed (as previously explained);
     \u2514\u2500 python [3.12.0|3.12.1|...|3.12.6] conflicts with any installable versions previously reported.

This happens even though the pyproject.toml of hydromt 0.10.0 states requires-python = ">=3.9", so I wonder where the lack of support for python 3.12 comes from.

I would recommend moving away from conda install in general since it is way faster. This would also make it possible to test the package for python 3.12

Use case

No response

Additional Context

Related issues:

@veenstrajelmer veenstrajelmer added the enhancement New feature or request label Sep 20, 2024
@veenstrajelmer veenstrajelmer linked a pull request Sep 25, 2024 that will close this issue
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant