Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix preprocessing of ring geometry #140

Open
2 tasks done
shartgring opened this issue Sep 25, 2024 · 0 comments
Open
2 tasks done

Bugfix preprocessing of ring geometry #140

shartgring opened this issue Sep 25, 2024 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@shartgring
Copy link
Collaborator

Version checks

  • I have checked that this issue has not already been reported.
  • I have checked that this bug exists on the latest version.

Reproducible Example

Has its origin in the Santa Cruz project and therefore santacruz branch. Depending on the type of projection, the code to remove duplicate in ring geometries may incorrectly assume that some points are duplicates. For some projections the relative 'magnitude' of 0.5 meter can be vary small compared to the x or y value. Therefore the tolerances of the code should be adressed in

duplicate_ids = np.isclose(first_nodes, last_nodes)

Current behaviour

Some points in ring geometries are incorrectly assumed to be duplicates

Desired behaviour

Adjust tolerances to relax this check

Additional context

No response

@shartgring shartgring added the bug Something isn't working label Sep 25, 2024
@shartgring shartgring self-assigned this Sep 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant