Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix setup_rivers for local model #194

Merged
merged 3 commits into from
Oct 18, 2024
Merged

Conversation

veenstrajelmer
Copy link
Collaborator

@veenstrajelmer veenstrajelmer commented Oct 18, 2024

Issue addressed

Fixes #175

Explanation

Adjusting the maxdist parameter for setup_rivers resolved the first two lines of warnings. The other warning is not a problem so it is converted from warning to info.

Checklist

  • Updated tests or added new tests
  • Branch is up to date with main
  • Tests & pre-commit hooks pass
  • Updated documentation if needed
  • Updated changelog.rst if needed >> not needed, only focusses on the example model for tests

Follow-up issue: #138

Copy link

sonarcloud bot commented Oct 18, 2024

@veenstrajelmer veenstrajelmer merged commit 47d6333 into main Oct 18, 2024
8 of 9 checks passed
@veenstrajelmer veenstrajelmer deleted the fix-crosssections-local-model branch October 18, 2024 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix No crossections are set up in setup_rivers for local model
2 participants