Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: add setup_cross_sections #96

Closed
roeldegoede opened this issue Jun 6, 2023 · 3 comments · Fixed by #114
Closed

ENH: add setup_cross_sections #96

roeldegoede opened this issue Jun 6, 2023 · 3 comments · Fixed by #114
Labels
Enhancement New feature or request

Comments

@roeldegoede
Copy link
Collaborator

To monitor the discharge in rivers, a crsfile can be defined in the following format:

crsfile = sfincs.crs

crs_01
2 2
453691 5410629
453307 5410240

crs_02
2 2
453691 5410629
453307 5410240

@roeldegoede roeldegoede added the Enhancement New feature or request label Jun 6, 2023
@roeldegoede roeldegoede linked a pull request Jul 28, 2023 that will close this issue
@lgrimley
Copy link

lgrimley commented Aug 3, 2023

I just tested this out... works great! One thing to add is clipping the cross-section geometry shapefile to the model domain in the setup function. Currently it writes all the input cross-sections to the model -- even ones outside the model area.

@roeldegoede
Copy link
Collaborator Author

Hi Lauren, nice to hear that it (almost) works for you!

So I just checked, and for me, cross-sections outside of the model region are clipped.. Something that we support since last release is that you can both provide in-memory datasets and filenames/dataset names from the data_catalog. We found out that the clipping doesn't work for the in-memory datasets (see also Deltares/hydromt#335).

Can this be an explanation why it didn't work for you?

@lgrimley
Copy link

lgrimley commented Aug 3, 2023

Ah, yes. That would be the reason it didn't clip. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants