Issue #996 Add missing dependency to Weekly CI pipeline. Cleanup code

Author: Manangka

.teamcity/Templates/AcceptanceTestsTemplate.kt

@@ -17,8 +17,8 @@ object AcceptanceTestsTemplate : Template({
 
 
     params {
-        param("env.access_key", "%credentialsJSON:2978988a-493b-44ed-9fcb-6cd6d2c2c673%")
-        param("env.secret_access_key", "%credentialsJSON:409a55c0-b2e7-438c-98dd-f0404b83cabb%")
+        password("env.access_key", "credentialsJSON:2978988a-493b-44ed-9fcb-6cd6d2c2c673")
+        password("env.secret_access_key", "credentialsJSON:409a55c0-b2e7-438c-98dd-f0404b83cabb")
     }
 
 

.teamcity/Weekly/WeeklyProject.kt

@@ -1,20 +1,16 @@
 package Weekly
 
 import Templates.*
-import jetbrains.buildServer.configs.kotlin.AbsoluteId
-import jetbrains.buildServer.configs.kotlin.BuildType
-import jetbrains.buildServer.configs.kotlin.DslContext
-import jetbrains.buildServer.configs.kotlin.FailureAction
-import jetbrains.buildServer.configs.kotlin.Project
+import jetbrains.buildServer.configs.kotlin.*
 import jetbrains.buildServer.configs.kotlin.buildFeatures.notifications
 import jetbrains.buildServer.configs.kotlin.triggers.ScheduleTrigger
 import jetbrains.buildServer.configs.kotlin.triggers.schedule
 
 object WeeklyProject : Project({
     name = "Weekly"
 
+    buildType(AcceptanceTests)
     buildType(WeeklyTests)
-
 })
 
 object AcceptanceTests : BuildType({
@@ -82,4 +78,10 @@ object  WeeklyTests : BuildType({
             buildFailed = true
         }
     }
+
+    dependencies {
+        snapshot(AcceptanceTests) {
+            onDependencyFailure = FailureAction.FAIL_TO_START
+        }
+    }
 })

.teamcity/_Self/MainProject.kt

@@ -34,6 +34,7 @@ object MainProject : Project({
     template(UnitTestsTemplate)
     template(ExamplesTemplate)
     template(PipPythonTemplate)
+    template(AcceptanceTestsTemplate)
 
     features {
         dockerRegistry {