Skip to content
This repository has been archived by the owner on Oct 30, 2018. It is now read-only.

Update diff view #11

Open
vmariano opened this issue Aug 20, 2014 · 12 comments
Open

Update diff view #11

vmariano opened this issue Aug 20, 2014 · 12 comments

Comments

@vmariano
Copy link
Contributor

As initial version we show red/green messages as change sets of the main bill's text.
The next step is show the difference at side of the main text like medium comments.

medium-side-comments

The objective is better understand of the change, avoiding be so invasive in the colors, and differences.

@vmariano
Copy link
Contributor Author

I'm not sure how should be highlighted the modified paragraph. Maybe an icon on the left side, and when press / hover. highlight the paragraph with the old version.

@gvilarino
Copy link
Member

I believe an icon on the side should always be present when there's a diff. On-hover could be mis-interpreted as the side-comments featura and would also demand the user to navigate the whole bill looking for diffs with his mouse.

@vmariano
Copy link
Contributor Author

I believe an icon on the side should always be present when there's a diff.

👍 I didn’t see in other way.

On-hover could be mis-interpreted as the side-comments feature and would also demand the user to navigate the whole bill looking for diffs with his mouse.

I explain better, I thought in something like:
2014-09-24 14 19 34

The border can be show it on over / or click.
About the nav of the whole law, what do you suggest? To see each change, the user must see the whole text.

@gvilarino
Copy link
Member

I sort of understand what you mean but I'm not sure I'm getting the whole picture. What would the diff-display feel like? I imagined either some sort of pop-up or a medium-like horizontal sliding that displays the actual diff.

Also, about navigation. I'm not sure either; maybe we could think of something similar to text navigation on the right, though it seems a bit far-fetched right now.
screen shot 2014-09-25 at 12 42 09 am

The more I think about this, the more I believe there should be two "modes" for a law:

  • Plain mode: you see the bill text as a whole, with a little mark on the right whenever there's been a change (and it displays when you click on it).
  • Diff mode: you only see snippets of diffs, more or less like what github shows for a commit.

Thoughts?

@vmariano
Copy link
Contributor Author

I sort of understand what you mean but I'm not sure I'm getting the whole picture. What would the diff-display feel like? I imagined either some sort of pop-up or a medium-like horizontal sliding that displays the actual diff.

Yeah, that was I try to figure in my draw.
nmilmhf

Also is hard to imagine something where you compare medium side coments + github diff + side text as sublimetext

Can you get 5 min and draw something where you imagine whole thing together?

@gvilarino
Copy link
Member

I see. I like that. Is the dotted line always present or only when a diff is being displayed?

@vmariano
Copy link
Contributor Author

Is the dotted line always present or only when a diff is being displayed?

In the 1th version we can make present only on the over of the icon, and see what happen.

@gvilarino
Copy link
Member

Ok, let's go with that

@vmariano
Copy link
Contributor Author

vmariano commented Nov 7, 2014

#31 and #29 are related.

@gvilarino
Copy link
Member

@vmariano #31 and #31? Please elaborate :p

@vmariano
Copy link
Contributor Author

sorry, was #31 and #29

@vmariano
Copy link
Contributor Author

#29 (comment)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants