Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scanvi refmap fails when query_celltype not specified in yaml #213

Open
wlason opened this issue Mar 5, 2024 · 1 comment
Open

scanvi refmap fails when query_celltype not specified in yaml #213

wlason opened this issue Mar 5, 2024 · 1 comment

Comments

@wlason
Copy link
Contributor

wlason commented Mar 5, 2024

In pipeline.yaml for refmap, specifying query_celltype is optional and will default to celltype if None, however this line doesn't take into account that query_celltype may be unspecified, so the script fails if it is not specified.

L.warn("Acc: {}".format(np.mean(full_predictions == adata_full.obs.celltype)))

If query_celltype is None, we need to create a new column in obs called celltype first, or skip this if-statement.

@bio-la
Copy link
Collaborator

bio-la commented Mar 6, 2024

hey @wlason,
this line refers to the concatenated reference and query datasets, after the celltype prediction using the trained scanvi model. in the documentation
we specify that the query has to contain a column with the same name as the label (celltype in this case) you need to transfer from the reference, filled with "unknown". (these are standard scvi-tools rules for scanvi, not related to panpipes)

can you tell me if you found an issue with these instructions? thank you for reporting!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants