Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Panpipes ingest errros in writing out a concatenated MuData object when hashing abs are present in the prot modailty #280

Open
deevdevil88 opened this issue Jun 4, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@deevdevil88
Copy link
Contributor

deevdevil88 commented Jun 4, 2024

Panpipes ingest is erroring on the concat_adata.py step, when hashing_ab are present in the prot modality. The error is specifically in writng out the MuData object, after a hashin_ab mod is created. The error is a type erorr for converting non-string objects to strings for one of the columns in the hasing_ab var slot. please see the attached screen shot
. in the current case panpipes was installed in a python 3.10 venv. But this error has also been reproduced in a panpipes conda env.

@deevdevil88
Copy link
Contributor Author

deevdevil88 commented Jun 4, 2024

Current work around is to comment out line 224 in concat_adata.py to not write out a seperate hashing_ab modailty until i figure out how to fix the type erorr. This is in branch devika_interim.

@deevdevil88 deevdevil88 changed the title Panpipes ingest errros in writing out a concatenated MuData object when HTO is present in the prot modailty Panpipes ingest errros in writing out a concatenated MuData object when hashing abs are present in the prot modailty Jun 4, 2024
@bio-la
Copy link
Collaborator

bio-la commented Jun 12, 2024

thanks, i'll merge the PR but keep this issue open. if you can create the same object in an interactive session you can check which column of the hashing array is creating problems. my guess is that the .var array has the hashing names and the count values in different columns and the names should be converted to categorical before adding them as var.
if you get round it (or have an example dataset i can use to test) we will put a fix in the next version.

@deevdevil88 deevdevil88 added the bug Something isn't working label Jun 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants