Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #307 #312

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Fix #307 #312

wants to merge 8 commits into from

Conversation

SarahOuologuem
Copy link
Collaborator

@SarahOuologuem SarahOuologuem commented Sep 3, 2024 •
edited
Loading

Added check for n_pcs < min(n_samples, n_features)
Added note to preprocess yaml documentation

@SarahOuologuem SarahOuologuem linked an issue Sep 3, 2024 that may be closed by this pull request
No control over number of PCs in batch_correct_none #307
Open
@SarahOuologuem SarahOuologuem marked this pull request as draft September 3, 2024 12:45
@SarahOuologuem SarahOuologuem marked this pull request as ready for review September 12, 2024 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bio-la bio-la Awaiting requested review from bio-la

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

No control over number of PCs in batch_correct_none
1 participant
@SarahOuologuem