Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate brax v2 in notebook brax_training #302

Open
gonzalesMK opened this issue Aug 11, 2024 · 2 comments
Open

Migrate brax v2 in notebook brax_training #302

gonzalesMK opened this issue Aug 11, 2024 · 2 comments

Comments

@gonzalesMK
Copy link

Hi!

I just tried to use this notebook: https://github.com/Denys88/rl_games/blob/master/notebooks/brax_training.ipynb and an import error occurred on this:

from brax import jumpy as jp

It seems brax has a new api (v2), and I fixed changing to this:

from brax.v1 import jumpy as jp
@gonzalesMK gonzalesMK changed the title Migrate brax v2 in notebook bax_training Migrate brax v2 in notebook brax_training Aug 11, 2024
@ViktorM
Copy link
Collaborator

ViktorM commented Aug 12, 2024

Thanks @gonzalesMK for the finding! Could you please create a PR with the fix? Also hopefully their API is much more stable now I can take a look again into updating to the latest v2.

@gonzalesMK
Copy link
Author

Sure! I can do that.

@amrzv amrzv mentioned this issue Nov 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants