From 223a87c7cc8f42a394f7e09111a1ba7bac13fe3f Mon Sep 17 00:00:00 2001
From: Der_Googler <54764558+DerGoogler@users.noreply.github.com>
Date: Wed, 15 May 2024 22:37:53 +0200
Subject: [PATCH] antifeatures

---
 .../src/components/AntiFeatureListItem.tsx    |  17 +--
 Website/src/components/AntifeaturesButton.tsx |  48 +++++++
 .../src/components/module/DeviceModule.tsx    |  11 ++
 .../src/components/module/ExploreModule.tsx   | 119 ++++++++++--------
 Website/src/locales/antifeatures/en.ts        |  57 +++++++++
 Website/src/typings/global.d.ts               |   2 +-
 Website/src/util/blacklisted-modules.ts       |   6 +
 7 files changed, 196 insertions(+), 64 deletions(-)
 create mode 100644 Website/src/components/AntifeaturesButton.tsx
 create mode 100644 Website/src/locales/antifeatures/en.ts
 create mode 100644 Website/src/util/blacklisted-modules.ts

diff --git a/Website/src/components/AntiFeatureListItem.tsx b/Website/src/components/AntiFeatureListItem.tsx
index b48885a3..b6f7da8e 100644
--- a/Website/src/components/AntiFeatureListItem.tsx
+++ b/Website/src/components/AntiFeatureListItem.tsx
@@ -1,26 +1,21 @@
 import { useStrings } from "@Hooks/useStrings";
-import Avatar from "@mui/material/Avatar";
-import Card from "@mui/material/Card";
-import CardContent from "@mui/material/CardContent";
 import ListItem from "@mui/material/ListItem";
-import ListItemAvatar from "@mui/material/ListItemAvatar";
-import ListItemText from "@mui/material/ListItemText";
-import Stack from "@mui/material/Stack";
-import Typography from "@mui/material/Typography";
-import ImageIcon from "@mui/icons-material/Image";
+import { en_antifeatures } from "./../locales/antifeatures/en";
 import React from "react";
+import { ListItemText } from "@mui/material";
 
 interface AntiFeatureListItemProps {
   type: string;
 }
 
 const AntiFeatureListItem = (props: AntiFeatureListItemProps) => {
-  const { strings } = useStrings();
+  const find = React.useMemo(() => en_antifeatures.find((anti) => anti.id === props.type), []);
+
+  if (!find) return null;
 
   return (
     <ListItem disablePadding>
-      {/* @ts-ignore */}
-      <ListItemText primary={props.type} secondary={strings(`AntiFeature_${props.type}_desc`)} />
+      <ListItemText primary={find.name} secondary={find.desc} />
     </ListItem>
   );
 };
diff --git a/Website/src/components/AntifeaturesButton.tsx b/Website/src/components/AntifeaturesButton.tsx
new file mode 100644
index 00000000..66f4c5a6
--- /dev/null
+++ b/Website/src/components/AntifeaturesButton.tsx
@@ -0,0 +1,48 @@
+import { Dialog, DialogActions, DialogContent, DialogContentText, DialogTitle, List, SxProps } from "@mui/material";
+import Button from "@mui/material/Button";
+import WarningAmberIcon from "@mui/icons-material/WarningAmber";
+import React from "react";
+import { useStrings } from "@Hooks/useStrings";
+import AntiFeatureListItem from "./AntiFeatureListItem";
+
+type Props = {
+  sx?: SxProps;
+  antifeatures?: Track["antifeatures"];
+};
+
+export const AntifeatureButton = (props: Props) => {
+  const [open, setOpen] = React.useState(false);
+
+  const { strings } = useStrings();
+
+  const handleClickOpen = () => {
+    setOpen(true);
+  };
+
+  const handleClose = () => {
+    setOpen(false);
+  };
+
+  return (
+    <>
+      <Button onClick={handleClickOpen} sx={props.sx} variant="contained" color="error" startIcon={<WarningAmberIcon />}>
+        {strings("antifeatures")}
+      </Button>
+      <Dialog open={open} onClose={handleClose} scroll="paper">
+        <DialogTitle>{strings("antifeatures")}</DialogTitle>
+        <DialogContent dividers>
+          <List disablePadding>
+            {typeof props.antifeatures === "string" ? (
+              <AntiFeatureListItem type={props.antifeatures} />
+            ) : (
+              Array.isArray(props.antifeatures) && props.antifeatures.map((anti) => <AntiFeatureListItem type={anti} />)
+            )}
+          </List>
+        </DialogContent>
+        <DialogActions>
+          <Button onClick={handleClose}>{strings("cancel")}</Button>
+        </DialogActions>
+      </Dialog>
+    </>
+  );
+};
diff --git a/Website/src/components/module/DeviceModule.tsx b/Website/src/components/module/DeviceModule.tsx
index 7d086ec3..78d88ee2 100644
--- a/Website/src/components/module/DeviceModule.tsx
+++ b/Website/src/components/module/DeviceModule.tsx
@@ -23,6 +23,8 @@ import { SuFile } from "@Native/SuFile";
 import { useConfirm } from "material-ui-confirm";
 import Switch from "@mui/material/Switch";
 import { Image } from "@Components/dapi/Image";
+import { blacklistedModules } from "@Util/blacklisted-modules";
+import { AntifeatureButton } from "@Components/AntifeaturesButton";
 
 interface Props {
   module: Module;
@@ -59,6 +61,10 @@ const DeviceModule = React.memo<Props>((props) => {
   const boot_complete = SuFile.exist(format("BOOTCOMP"));
   const module_config_file = SuFile.exist(format("CONFINDEX"));
 
+  const findHardCodedAntifeature = React.useMemo<Track["antifeatures"]>(() => {
+    return blacklistedModules[id]?.antifeatures || [];
+  }, [id]);
+
   return (
     <Card sx={{ position: "relative", p: 2, width: "100%" }}>
       <Stack sx={{ position: "relative", zIndex: 1 }} direction="column" justifyContent="center" spacing={1}>
@@ -167,6 +173,11 @@ const DeviceModule = React.memo<Props>((props) => {
             </Stack>
             <Divider variant="middle" />
             <Stack direction="row" justifyContent="flex-end" alignItems="center" spacing={1}>
+              {findHardCodedAntifeature && findHardCodedAntifeature.length !== 0 && (
+                <Stack direction="row" justifyContent="flex-end" alignItems="center" spacing={2}>
+                  <AntifeatureButton antifeatures={findHardCodedAntifeature} />
+                </Stack>
+              )}
               <Button
                 onClick={() => {
                   context.pushPage({
diff --git a/Website/src/components/module/ExploreModule.tsx b/Website/src/components/module/ExploreModule.tsx
index 3c3afea5..0b0caa21 100644
--- a/Website/src/components/module/ExploreModule.tsx
+++ b/Website/src/components/module/ExploreModule.tsx
@@ -5,7 +5,6 @@ import Card from "@mui/material/Card";
 import Stack from "@mui/material/Stack";
 import Chip from "@mui/material/Chip";
 import Divider from "@mui/material/Divider";
-import CardMedia from "@mui/material/CardMedia";
 import WarningAmberIcon from "@mui/icons-material/WarningAmber";
 import ModuleViewActivity from "@Activitys/ModuleViewActivity/index";
 import { useFormatDate } from "@Hooks/useFormatDate";
@@ -15,6 +14,9 @@ import { GestureDetector } from "@Components/onsenui/GestureDetector";
 import { useTheme } from "@Hooks/useTheme";
 import { VerifiedIcon } from "@Components/icons/VerifiedIcon";
 import { Image } from "@Components/dapi/Image";
+import Box from "@mui/material/Box";
+import { AntifeatureButton } from "@Components/AntifeaturesButton";
+import { blacklistedModules } from "@Util/blacklisted-modules";
 
 interface Props {
   module: Module;
@@ -29,6 +31,10 @@ const ExploreModule = React.memo<Props>((props) => {
 
   const formatLastUpdate = useFormatDate(timestamp ? timestamp : versions[versions.length - 1].timestamp);
 
+  const findHardCodedAntifeature = React.useMemo<Track["antifeatures"]>(() => {
+    return [...(track.antifeatures || []), ...(blacklistedModules[id]?.antifeatures || [])];
+  }, [id, track.antifeatures]);
+
   const handleOpenModule = () => {
     context.pushPage({
       component: ModuleViewActivity,
@@ -38,64 +44,73 @@ const ExploreModule = React.memo<Props>((props) => {
   };
 
   return (
-    <Card
-      onTap={handleOpenModule}
-      component={GestureDetector}
-      sx={{
-        p: 2,
-        ":hover": {
-          opacity: ".8",
-          cursor: "pointer",
-        },
-        width: "100%",
-      }}
-    >
-      <Stack direction="column" justifyContent="center" spacing={1}>
-        {track.cover && (
-          <Image
-            sx={{
-              height: "100%",
-              objectFit: "cover",
-              width: "100%",
-            }}
-            src={track.cover}
-            alt={name}
-            noOpen
-          />
-        )}
-
-        <Stack direction="column" justifyContent="center" alignItems="flex-start">
-          <Stack direction="row" justifyContent="flex-start" alignItems="center" spacing={0.5}>
-            <Typography variant="h6">{name}</Typography>
-            <VerifiedIcon isVerified={track.verified} />
-          </Stack>
-
-          <Typography color="text.secondary" variant="caption">
-            {version} ({versionCode}) / {author}
-          </Typography>
-        </Stack>
-        <Typography color="text.secondary" variant="body2" display="block">
-          {description}
-        </Typography>
-        <Stack direction="column" justifyContent="center" spacing={1.2}>
-          <Divider variant="middle" />
-          <Stack direction="row" justifyContent="space-between" alignItems="center" spacing={1}>
-            <Chip
+    <Box>
+      <Card
+        onTap={handleOpenModule}
+        component={GestureDetector}
+        sx={{
+          ...(track.antifeatures && {
+            borderRadius: `${theme.shape.borderRadius}px ${theme.shape.borderRadius}px 0px ${theme.shape.borderRadius}px`,
+          }),
+          p: 2,
+          ":hover": {
+            opacity: ".8",
+            cursor: "pointer",
+          },
+          width: "100%",
+        }}
+      >
+        <Stack direction="column" justifyContent="center" spacing={1}>
+          {track.cover && (
+            <Image
               sx={{
-                bgColor: "secondary.dark",
+                height: "100%",
+                objectFit: "cover",
+                width: "100%",
               }}
-              label={formatLastUpdate}
+              src={track.cover}
+              alt={name}
+              noOpen
             />
+          )}
 
-            <Stack direction="row" justifyContent="flex-end" alignItems="center" spacing={1}>
-              {track.antifeatures && (
-                <Chip variant="outlined" color="warning" label="Anti-Features" size="small" icon={<WarningAmberIcon />} />
-              )}
+          <Stack direction="column" justifyContent="center" alignItems="flex-start">
+            <Stack direction="row" justifyContent="flex-start" alignItems="center" spacing={0.5}>
+              <Typography variant="h6">{name}</Typography>
+              <VerifiedIcon isVerified={track.verified} />
             </Stack>
+
+            <Typography color="text.secondary" variant="caption">
+              {version} ({versionCode}) / {author}
+            </Typography>
           </Stack>
+          <Typography color="text.secondary" variant="body2" display="block">
+            {description}
+          </Typography>
+          <Stack direction="column" justifyContent="center" spacing={1.2}>
+            <Divider variant="middle" />
+            <Stack direction="row" justifyContent="space-between" alignItems="center" spacing={1}>
+              <Chip
+                sx={{
+                  bgColor: "secondary.dark",
+                }}
+                label={formatLastUpdate}
+              />
+
+              <Stack direction="row" justifyContent="flex-end" alignItems="center" spacing={1}></Stack>
+            </Stack>
+          </Stack>
+        </Stack>
+      </Card>
+      {findHardCodedAntifeature && findHardCodedAntifeature.length !== 0 && (
+        <Stack direction="row" justifyContent="flex-end" alignItems="center" spacing={2}>
+          <AntifeatureButton
+            antifeatures={findHardCodedAntifeature}
+            sx={{ borderRadius: `0px 0px ${theme.shape.borderRadius}px ${theme.shape.borderRadius}px` }}
+          />
         </Stack>
-      </Stack>
-    </Card>
+      )}
+    </Box>
   );
 });
 
diff --git a/Website/src/locales/antifeatures/en.ts b/Website/src/locales/antifeatures/en.ts
new file mode 100644
index 00000000..ca6ae248
--- /dev/null
+++ b/Website/src/locales/antifeatures/en.ts
@@ -0,0 +1,57 @@
+export const en_antifeatures = [
+  {
+    id: "Ads",
+    name: "Advertising",
+    desc: "The module contains advertisements.",
+  },
+  {
+    id: "KnownVuln",
+    name: "Known Vulnerability",
+    desc: "This app contains a known security vulnerability",
+  },
+  {
+    id: "NSFW",
+    name: "NSFW",
+    desc: "This app contains content that should not be publicized or visible everywhere",
+  },
+  {
+    id: "NoSourceSince",
+    name: "No Source Since",
+    desc: "The source code is no longer available, no updates possible.",
+  },
+  {
+    id: "NonFreeAdd",
+    name: "Non-Free Addons",
+    desc: "This app promotes non-free add-ons",
+  },
+  {
+    id: "NonFreeAssets",
+    name: "Non-Free Assets",
+    desc: "This app contains non-free assets",
+  },
+  {
+    id: "NonFreeDep",
+    name: "Non-Free Dependencies",
+    desc: "This app depends on other non-free apps",
+  },
+  {
+    id: "NonFreeNet",
+    name: "Non-Free Network Services",
+    desc: "This app promotes or depends entirely on a non-changeable or non-free network service",
+  },
+  {
+    id: "Tracking",
+    name: "Tracking",
+    desc: "This app tracks and reports your activity",
+  },
+  {
+    id: "UpstreamNonFree",
+    name: "Upstream Non-Free",
+    desc: "The upstream source code is not entirely Free",
+  },
+  {
+    id: "Obfuscation",
+    name: "Obfuscation",
+    desc: "The app source code is may obfuscated, making it difficult to understand, audit, or modify.",
+  },
+];
diff --git a/Website/src/typings/global.d.ts b/Website/src/typings/global.d.ts
index f90bb7a9..945a4310 100644
--- a/Website/src/typings/global.d.ts
+++ b/Website/src/typings/global.d.ts
@@ -214,7 +214,7 @@ declare global {
     categories?: string[];
     stars?: number;
     readme?: string;
-    antifeatures?: AntiFeatures | AntiFeatures[];
+    antifeatures?: string | string[] | AntiFeatures | AntiFeatures[];
   }
 
   type AntiFeatures =
diff --git a/Website/src/util/blacklisted-modules.ts b/Website/src/util/blacklisted-modules.ts
new file mode 100644
index 00000000..3152ff3f
--- /dev/null
+++ b/Website/src/util/blacklisted-modules.ts
@@ -0,0 +1,6 @@
+export const blacklistedModules = {
+  zygisksu: {
+    hidden: false,
+    antifeatures: ["Obfuscation", "NoSourceSince"],
+  },
+};