Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

properly releasing resources (filehandles) #3

Closed
alpae opened this issue Dec 22, 2023 · 1 comment
Closed

properly releasing resources (filehandles) #3

alpae opened this issue Dec 22, 2023 · 1 comment

Comments

@alpae
Copy link
Member

alpae commented Dec 22, 2023

Seems like omadb client does not properly release resources (DessimozLab/OMArk#25)

putting the client as a module variable does not help, so it seems that we should use requests session to recycle the connections. (by default, omadb does not use the CachedSession.
@alex-wave alex-wave transferred this issue from DessimozLab/OmaDB Jan 17, 2024
@alex-wave
Copy link
Collaborator

This should be fixed in the new release v2.2.4, where we now use Session / CachedSession dependent on the setting persistent_cached.

If this is still an issue, I can investigate further.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@alpae @alex-wave