report explicit usages of the Any type

DetachHead · Nov 14, 2024 · bc635fd · bc635fd
1 parent cb30c33
commit bc635fd
Show file tree

Hide file tree

Showing 4 changed files with 11 additions and 1 deletion.
diff --git a/packages/pyright-internal/src/analyzer/checker.ts b/packages/pyright-internal/src/analyzer/checker.ts
@@ -1481,6 +1481,10 @@ export class Checker extends ParseTreeWalker {
         const type = this._evaluator.getType(node);
         this._reportDeprecatedUseForType(node, type);
 
+        if (type && isAny(type) && type.props?.specialForm) {
+            this._evaluator.addDiagnostic(DiagnosticRule.reportAny, LocMessage.explicitAny(), node);
+        }
+
         return true;
     }
 

diff --git a/packages/pyright-internal/src/localization/localize.ts b/packages/pyright-internal/src/localization/localize.ts
@@ -1241,6 +1241,7 @@ export namespace Localizer {
             new ParameterizedString<{ classes: string }>(getRawString('Diagnostic.multipleInheritance'));
         export const unannotatedClassAttribute = () =>
             new ParameterizedString<{ name: string }>(getRawString('Diagnostic.unannotatedClassAttribute'));
+        export const explicitAny = () => getRawString('Diagnostic.explicitAny');
     }
 
     export namespace DiagnosticAddendum {

diff --git a/packages/pyright-internal/src/localization/package.nls.en-us.json b/packages/pyright-internal/src/localization/package.nls.en-us.json
@@ -1730,7 +1730,8 @@
         "implicitRelativeImport": "Import from `{importName}` is implicitly relative and will not work if this file is imported as a module",
         "invalidCast": "Conversion of type `{fromType}` to type `{toType}` may be a mistake because neither type sufficiently overlaps with the other. If this was intentional, convert the expression to `object` first.",
         "multipleInheritance": "Multiple inheritance is not allowed because the following base classes contain `__init__` or `__new__` methods that may not get called: {classes}",
-        "unannotatedClassAttribute": "Type annotation for attribute `{name}` is required because this class is not decorated with `@final`"
+        "unannotatedClassAttribute": "Type annotation for attribute `{name}` is required because this class is not decorated with `@final`",
+        "explicitAny": "The `Any` type is not allowed"
     },
     "DiagnosticAddendum": {
         "annotatedNotAllowed": {

diff --git a/packages/pyright-internal/src/tests/reportAny.test.ts b/packages/pyright-internal/src/tests/reportAny.test.ts
@@ -12,6 +12,8 @@ test('reportAny', () => {
     validateResultsButBased(analysisResults, {
         errors: [
             { line: 3, code: DiagnosticRule.reportAny, message: LocMessage.returnTypeAny() },
+            { line: 3, code: DiagnosticRule.reportAny, message: LocMessage.explicitAny() },
+            { line: 3, code: DiagnosticRule.reportAny, message: LocMessage.explicitAny() },
             {
                 line: 3,
                 code: DiagnosticRule.reportAny,
@@ -20,6 +22,7 @@ test('reportAny', () => {
             { line: 4, code: DiagnosticRule.reportAny },
             { line: 5, code: DiagnosticRule.reportAny, message: LocMessage.returnTypeAny() },
             { line: 7, code: DiagnosticRule.reportAny, message: LocMessage.typeAny().format({ name: 'bar' }) },
+            { line: 7, code: DiagnosticRule.reportAny, message: LocMessage.explicitAny() },
             {
                 line: 9,
                 code: DiagnosticRule.reportAny,
@@ -40,6 +43,7 @@ test('reportAny', () => {
                 code: DiagnosticRule.reportAny,
                 message: LocMessage.lambdaReturnTypeAny(),
             },
+            { line: 15, code: DiagnosticRule.reportAny, message: LocMessage.explicitAny() },
             {
                 line: 18,
                 code: DiagnosticRule.reportAny,