use new nodejs-wheel-binaries package

DetachHead · May 8, 2024 · d6d39c5 · d6d39c5
1 parent ce5e40c
commit d6d39c5
Show file tree

Hide file tree

Showing 2 changed files with 32 additions and 29 deletions.
diff --git a/pdm.lock b/pdm.lock
diff --git a/pyproject.toml b/pyproject.toml
@@ -27,8 +27,9 @@ authors = [
     { name = "detachhead", email = "[email protected]" },
 ]
 dependencies = [
-    # required by the basedpyright cli & langserver wrapper scripts
-    "nodejs-wheel>=20.12.2",
+    # required by the basedpyright cli & langserver wrapper scripts. only binaries are required (no cli)
+    # since the user shouldn't have a node/npm binary unknowingly added to their PATH
+    "nodejs-wheel-binaries>=20.12.2",
 ]
 requires-python = ">=3.8"
 readme = "README.md"
@@ -44,7 +45,8 @@ basedpyright-langserver = 'basedpyright.langserver:main'
 [build-system]
 requires = [
     "pdm-backend",
-    # required for building the pyright npm package to be bundled in the pypi package:
+    # required for building the pyright npm package to be bundled in the pypi package.
+    # cli is required due to dependencies with install scripts that assume node/npm is in the path
     "nodejs-wheel>=20.12.2",
 ]
 build-backend = "pdm.backend"