Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reportImplicitOverride false negative when overridden method has decorator with Callable type #915

Open
DetachHead opened this issue Nov 28, 2024 · 0 comments
Labels
type checking / linting issues relating to existing diagnostic rules or proposals for new diagnostic rules upstream bug a bug that also exists in pyright but has not been raised upstream

Comments

@DetachHead
Copy link
Owner

Code sample in basedpyright playground

from abc import abstractmethod
from typing import Callable


def deco[**P, T](value: Callable[P, T]) -> Callable[P, T]:
    return value


class Foo:
    @abstractmethod
    def foo(self): ...


class Bar(Foo):
    @deco
    def foo(self): ... # no error
@DetachHead DetachHead added type checking / linting issues relating to existing diagnostic rules or proposals for new diagnostic rules upstream bug a bug that also exists in pyright but has not been raised upstream labels Nov 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type checking / linting issues relating to existing diagnostic rules or proposals for new diagnostic rules upstream bug a bug that also exists in pyright but has not been raised upstream
Projects
None yet
Development

No branches or pull requests

1 participant