Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[LSP Spec]: In response of signatureHelp, activeSignature starts from 1 #972

Open
jinzhongjia opened this issue Jan 1, 2025 · 5 comments
Labels
awaiting response waiting for more info from the author - will eventually close if they don't respond language server

Comments

@jinzhongjia
Copy link

I recently discovered a problem when using basedpyright on neovim
But this problem should not require code to reproduce. You only need to find a python method with parameters to verify it.

main

https://microsoft.github.io/language-server-protocol/specifications/lsp/3.17/specification/#signatureHelp

According to doc, activeSignature should start from 0, but now it is start from 1

I'm not sure if this is really a problem, so I'll ask and if there is no problem please close the issue.

@KotlinIsland KotlinIsland added language server needs investigation awaiting verification by a maintainer that the issue is valid labels Jan 1, 2025
@jinzhongjia
Copy link
Author

jinzhongjia commented Jan 1, 2025

I tested it further and found that the signaturehelp of list.sort() is incorrect. It starts from 1
But the signaturehelp of print() is correct, it starts from 0

This behavior is strange

@KotlinIsland
Copy link
Collaborator

KotlinIsland commented Jan 2, 2025

is activeSignature related to overloads?

could you please provide steps on how to reproduce this? something like:

  1. enter
    print()
    list.sort()
  2. check language server logs for signatureHelp response

@DetachHead
Copy link
Owner

yeah i don't really understand what signatureHelp is and the language server documentation doesn't have any screenshots so i will need some more information. preferably a screenshot of what exactly is incorrect with list.sort() compared to print()

@DetachHead DetachHead added awaiting response waiting for more info from the author - will eventually close if they don't respond language server and removed language server needs investigation awaiting verification by a maintainer that the issue is valid labels Jan 3, 2025
@jinzhongjia
Copy link
Author

I will try to check the logs later

@KotlinIsland
Copy link
Collaborator

when you say that it "starts from 1", what exactly do you mean? how do you know that it is starting from 1? where you can see this information?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting response waiting for more info from the author - will eventually close if they don't respond language server
Projects
None yet
Development

No branches or pull requests

3 participants