Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dont disable import suggestion code actions when autoImportCompletions is disabled #974

Closed
igorechek06 opened this issue Jan 3, 2025 · 4 comments · Fixed by #983
Closed

dont disable import suggestion code actions when autoImportCompletions is disabled #974

igorechek06 opened this issue Jan 3, 2025 · 4 comments · Fixed by #983
Labels
config issues relating to config (pyproject.toml, pyrightconfig.json, LSP config or vscode extension) language server LSP: code actions LSP: completions

Comments

@igorechek06
Copy link

I don't use autoImportCompletions, but want to use import suggestion feature.
@KotlinIsland KotlinIsland added the config issues relating to config (pyproject.toml, pyrightconfig.json, LSP config or vscode extension) label Jan 3, 2025
@DetachHead
Copy link
Owner

do you mean you want import suggestions for code actions / quick fixes but not completions?

@DetachHead DetachHead added LSP: code actions awaiting response waiting for more info from the author - will eventually close if they don't respond LSP: completions language server labels Jan 5, 2025
@igorechek06
Copy link
Author

Yes, only quick fixes.

@igorechek06
Copy link
Author

I would like to separate these functions. Separately quick fixes and separately completions.

@DetachHead DetachHead changed the title Add parameter for import suggestion feature dont disable import suggestion code actions when autoImportCompletions is disabled Jan 5, 2025
@DetachHead DetachHead removed the awaiting response waiting for more info from the author - will eventually close if they don't respond label Jan 5, 2025
@DetachHead
Copy link
Owner

yeah this setting should never have been applied to code actions

@DetachHead DetachHead mentioned this issue Jan 6, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
config issues relating to config (pyproject.toml, pyrightconfig.json, LSP config or vscode extension) language server LSP: code actions LSP: completions
Projects
None yet
Milestone
No milestone
3 participants
@igorechek06 @DetachHead @KotlinIsland