Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't hardcode the path #1318

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Don't hardcode the path #1318

wants to merge 1 commit into from

Conversation

aaomidi
Copy link

@aaomidi aaomidi commented Nov 26, 2024 •
edited
Loading

Description

Fixes #1296

Checklist
  • Formatted with cargo fmt
  • Built with nix build
  • Ran flake checks with nix flake check
  • Added or updated relevant tests (leave unchecked if not applicable)
  • Added or updated relevant documentation (leave unchecked if not applicable)
  • Linked to related issues (leave unchecked if not applicable)
Validating with install.determinate.systems

If a maintainer has added the upload to s3 label to this PR, it will become available for installation via install.determinate.systems:

curl --proto '=https' --tlsv1.2 -sSf -L https://install.determinate.systems/nix/pr/$PR_NUMBER | sh -s -- install

@aaomidi aaomidi force-pushed the amir/allow_variable_path_handling branch from 7552c12 to e2863ba Compare November 26, 2024 07:19
@aaomidi aaomidi force-pushed the amir/allow_variable_path_handling branch from e2863ba to 65998de Compare November 26, 2024 07:22
@hispirus
Copy link

hispirus commented Dec 3, 2024

Hi @aaomidi! This PR looks like it presents an alternative approach to the fundamental problem solved by #1236.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

NIX_INSTALLER_VOLUME_LABEL does not work
2 participants
@aaomidi @hispirus