DataGrid - remove height warning from known list (#2956)

* fix * fix treelist adaptability demo * fix TreeList-FormEditing demo * fix TreeList-CustomizeKeyboardNavigation * add missing ids * fix * fix lint
DevExpress · Dec 1, 2023 · 37f274f · 37f274f
1 parent 8d35b3c
commit 37f274f
Show file tree

Hide file tree

Showing 29 changed files with 90 additions and 26 deletions.
diff --git a/JSDemos/Demos/TreeList/Adaptability/Angular/app/app.component.css b/JSDemos/Demos/TreeList/Adaptability/Angular/app/app.component.css
@@ -1,3 +1,4 @@
 #employees {
   padding: 10px;
+  max-height: 440px;
 }
diff --git a/JSDemos/Demos/TreeList/Adaptability/React/styles.css b/JSDemos/Demos/TreeList/Adaptability/React/styles.css
@@ -1,3 +1,4 @@
 #employees {
   padding: 10px;
+  max-height: 440px;
 }
diff --git a/JSDemos/Demos/TreeList/Adaptability/ReactJs/styles.css b/JSDemos/Demos/TreeList/Adaptability/ReactJs/styles.css
@@ -1,3 +1,4 @@
 #employees {
   padding: 10px;
+  max-height: 440px;
 }
diff --git a/JSDemos/Demos/TreeList/Adaptability/Vue/App.vue b/JSDemos/Demos/TreeList/Adaptability/Vue/App.vue
@@ -49,5 +49,6 @@ const expandedRowKeys = [1];
 <style scoped>
 #employees {
   padding: 10px;
+  max-height: 440px;
 }
 </style>
diff --git a/JSDemos/Demos/TreeList/Adaptability/jQuery/styles.css b/JSDemos/Demos/TreeList/Adaptability/jQuery/styles.css
@@ -1,3 +1,4 @@
 #employees {
   padding: 10px;
+  max-height: 440px;
 }
diff --git a/JSDemos/Demos/TreeList/CustomizeKeyboardNavigation/Angular/app/app.component.css b/JSDemos/Demos/TreeList/CustomizeKeyboardNavigation/Angular/app/app.component.css
@@ -1,3 +1,7 @@
+#employees {
+  max-height: 640px;
+}
+
 .options {
   margin-top: 20px;
   padding: 20px;

diff --git a/JSDemos/Demos/TreeList/CustomizeKeyboardNavigation/React/styles.css b/JSDemos/Demos/TreeList/CustomizeKeyboardNavigation/React/styles.css
@@ -1,3 +1,7 @@
+#employees {
+  max-height: 640px;
+}
+
 .options {
   margin-top: 20px;
   padding: 20px;

diff --git a/JSDemos/Demos/TreeList/CustomizeKeyboardNavigation/ReactJs/styles.css b/JSDemos/Demos/TreeList/CustomizeKeyboardNavigation/ReactJs/styles.css
@@ -1,3 +1,7 @@
+#employees {
+  max-height: 640px;
+}
+
 .options {
   margin-top: 20px;
   padding: 20px;

diff --git a/JSDemos/Demos/TreeList/CustomizeKeyboardNavigation/Vue/styles.css b/JSDemos/Demos/TreeList/CustomizeKeyboardNavigation/Vue/styles.css
@@ -1,3 +1,7 @@
+#employees {
+  max-height: 640px;
+}
+
 .options {
   margin-top: 20px;
   padding: 20px;

diff --git a/JSDemos/Demos/TreeList/CustomizeKeyboardNavigation/jQuery/index.html b/JSDemos/Demos/TreeList/CustomizeKeyboardNavigation/jQuery/index.html
@@ -15,22 +15,20 @@
 
   <body class="dx-viewport">
     <div class="demo-container">
-      <div id="tree-list-demo">
-        <div id="employees"></div>
-        <div class="options">
-          <div class="caption">Options</div>
-          <div class="option-container">
-            <div class="option check-box">
-              <div id="editOnKeyPress"></div>
-            </div>
-            <div class="option">
-              <span class="option-caption">Enter Key Action</span>
-              <div class="select" id="enterKeyAction"></div>
-            </div>
-            <div class="option">
-              <span class="option-caption">Enter Key Direction</span>
-              <div class="select" id="enterKeyDirection"></div>
-            </div>
+      <div id="employees"></div>
+      <div class="options">
+        <div class="caption">Options</div>
+        <div class="option-container">
+          <div class="option check-box">
+            <div id="editOnKeyPress"></div>
+          </div>
+          <div class="option">
+            <span class="option-caption">Enter Key Action</span>
+            <div class="select" id="enterKeyAction"></div>
+          </div>
+          <div class="option">
+            <span class="option-caption">Enter Key Direction</span>
+            <div class="select" id="enterKeyDirection"></div>
           </div>
         </div>
       </div>

diff --git a/JSDemos/Demos/TreeList/CustomizeKeyboardNavigation/jQuery/styles.css b/JSDemos/Demos/TreeList/CustomizeKeyboardNavigation/jQuery/styles.css
@@ -2,6 +2,10 @@
   min-height: 700px;
 }
 
+#employees {
+  max-height: 640px;
+}
+
 .options {
   margin-top: 20px;
   padding: 20px;

diff --git a/JSDemos/Demos/TreeList/FormEditing/Angular/app/app.component.css b/JSDemos/Demos/TreeList/FormEditing/Angular/app/app.component.css
@@ -1,3 +1,7 @@
-::ng-deep #tree-list-demo {
+#tree-list-demo {
   min-height: 700px;
 }
+
+#employees {
+  max-height: 640px;
+}
diff --git a/JSDemos/Demos/TreeList/FormEditing/React/App.tsx b/JSDemos/Demos/TreeList/FormEditing/React/App.tsx
@@ -26,6 +26,7 @@ const onInitNewRow = (e: TreeListTypes.InitNewRowEvent) => {
 const App = () => (
   <div id="tree-list-demo">
     <TreeList
+      id="employees"
       dataSource={employees}
       columnAutoWidth={true}
       showRowLines={true}

diff --git a/JSDemos/Demos/TreeList/FormEditing/React/styles.css b/JSDemos/Demos/TreeList/FormEditing/React/styles.css
@@ -1,3 +1,7 @@
 #tree-list-demo {
   min-height: 700px;
 }
+
+#employees {
+  max-height: 640px;
+}
diff --git a/JSDemos/Demos/TreeList/FormEditing/ReactJs/App.js b/JSDemos/Demos/TreeList/FormEditing/ReactJs/App.js
@@ -27,6 +27,7 @@ const onInitNewRow = (e) => {
 const App = () => (
   <div id="tree-list-demo">
     <TreeList
+      id="employees"
       dataSource={employees}
       columnAutoWidth={true}
       showRowLines={true}

diff --git a/JSDemos/Demos/TreeList/FormEditing/ReactJs/styles.css b/JSDemos/Demos/TreeList/FormEditing/ReactJs/styles.css
@@ -1,3 +1,7 @@
 #tree-list-demo {
   min-height: 700px;
 }
+
+#employees {
+  max-height: 640px;
+}
diff --git a/JSDemos/Demos/TreeList/FormEditing/Vue/App.vue b/JSDemos/Demos/TreeList/FormEditing/Vue/App.vue
@@ -108,4 +108,8 @@ function allowDeleting(e) {
 #tree-list-demo {
   min-height: 700px;
 }
+
+#employees {
+  max-height: 640px;
+}
 </style>
diff --git a/JSDemos/Demos/TreeList/FormEditing/jQuery/styles.css b/JSDemos/Demos/TreeList/FormEditing/jQuery/styles.css
@@ -1,3 +1,7 @@
 #tree-list-demo {
   min-height: 700px;
 }
+
+#employees {
+  max-height: 640px;
+}
diff --git a/JSDemos/Demos/TreeList/PopupEditing/React/App.tsx b/JSDemos/Demos/TreeList/PopupEditing/React/App.tsx
@@ -33,6 +33,7 @@ const onInitNewRow = (e: TreeListTypes.InitNewRowEvent) => {
 const App = () => (
   <div id="tree-list-demo">
     <TreeList
+      id="employees"
       dataSource={employees}
       columnAutoWidth={true}
       showRowLines={true}

diff --git a/JSDemos/Demos/TreeList/PopupEditing/ReactJs/App.js b/JSDemos/Demos/TreeList/PopupEditing/ReactJs/App.js
@@ -32,6 +32,7 @@ const onInitNewRow = (e) => {
 const App = () => (
   <div id="tree-list-demo">
     <TreeList
+      id="employees"
       dataSource={employees}
       columnAutoWidth={true}
       showRowLines={true}

diff --git a/JSDemos/Demos/TreeList/SingleRowSelection/React/App.tsx b/JSDemos/Demos/TreeList/SingleRowSelection/React/App.tsx
@@ -6,6 +6,7 @@ const expandedRowKeys = [1];
 
 const App = () => (
   <TreeList
+    id="employees"
     dataSource={employees}
     showRowLines={true}
     showBorders={true}

diff --git a/JSDemos/Demos/TreeList/SingleRowSelection/ReactJs/App.js b/JSDemos/Demos/TreeList/SingleRowSelection/ReactJs/App.js
@@ -5,6 +5,7 @@ import { employees } from './data.js';
 const expandedRowKeys = [1];
 const App = () => (
   <TreeList
+    id="employees"
     dataSource={employees}
     showRowLines={true}
     showBorders={true}

diff --git a/MVCDemos/Content/DemosStyles/TreeList/Adaptability.css b/MVCDemos/Content/DemosStyles/TreeList/Adaptability.css
@@ -1,3 +1,4 @@
 #employees {
     padding: 10px;
-}
+    max-height: 440px;
+}
diff --git a/MVCDemos/Content/DemosStyles/TreeList/CustomizeKeyboardNavigation.css b/MVCDemos/Content/DemosStyles/TreeList/CustomizeKeyboardNavigation.css
@@ -1,4 +1,8 @@
-.options {
+#employees {
+    max-height: 640px;
+}  
+
+.options {
     margin-top: 20px;
     padding: 20px;
     background-color: rgba(191, 191, 191, 0.15);

diff --git a/MVCDemos/Content/DemosStyles/TreeList/FormEditing.css b/MVCDemos/Content/DemosStyles/TreeList/FormEditing.css
@@ -1,3 +1,8 @@
 #tree-list-demo {
     min-height: 700px;
-}
+}
+
+#employees {
+    max-height: 640px;
+}
+
diff --git a/NetCoreDemos/wwwroot/css/DemosStyles/TreeList/Adaptability.css b/NetCoreDemos/wwwroot/css/DemosStyles/TreeList/Adaptability.css
@@ -1,3 +1,4 @@
 #employees {
     padding: 10px;
-}
+    max-height: 440px;
+}
diff --git a/NetCoreDemos/wwwroot/css/DemosStyles/TreeList/CustomizeKeyboardNavigation.css b/NetCoreDemos/wwwroot/css/DemosStyles/TreeList/CustomizeKeyboardNavigation.css
@@ -1,4 +1,8 @@
-.options {
+#employees {
+    max-height: 640px;
+}  
+
+.options {
     margin-top: 20px;
     padding: 20px;
     background-color: rgba(191, 191, 191, 0.15);

diff --git a/NetCoreDemos/wwwroot/css/DemosStyles/TreeList/FormEditing.css b/NetCoreDemos/wwwroot/css/DemosStyles/TreeList/FormEditing.css
@@ -1,3 +1,4 @@
-#tree-list-demo {
-    min-height: 700px;
-}
+#employees {
+    max-height: 640px;
+}
+
diff --git a/testing/known-warnings.json b/testing/known-warnings.json
@@ -10,6 +10,5 @@
   "W0022 -",
   "W1011 -",
   "W1023 -",
-  "W1025 -",
   "W2108 -"
 ]