Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Staging to Main: Homepage REVAMP #289

Merged
merged 34 commits into from
Dec 17, 2024
Merged

Staging to Main: Homepage REVAMP #289

merged 34 commits into from
Dec 17, 2024

Conversation

Markkos89
Copy link
Collaborator

Changes

  • @rohann06 homepage background revamp update

removed the old code only for this section and wrote a new one with tailwind css
removed fixed keyword to allow the background image to scroll with the page.
added the learn web3 and partner with banners.
the banner section is complete
added the new dd logo resized all text size and the social icons
changed the design of the navigation bar also added the posts as a new nav option.
added the gradient border to the banners
updated partner count, adjusted post symbol and full stop graphic in hero, left aligned footer text.
In the landing page code, added the background image in the div. This caused it to be removed from
other pages.
@Markkos89 Markkos89 requested a review from uma-l October 3, 2024 07:46
@Markkos89 Markkos89 self-assigned this Oct 3, 2024
Copy link

vercel bot commented Oct 3, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
academy-turbo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 3, 2024 3:13pm
academy-turbo-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 3, 2024 3:13pm

@Markkos89 Markkos89 removed their assignment Oct 3, 2024
@Markkos89 Markkos89 marked this pull request as ready for review October 3, 2024 07:47
Copy link

github-actions bot commented Oct 3, 2024

⚡️ Lighthouse report for the changes in this PR:

Category Score
🔴 Performance 35
🟢 Accessibility 96
🟢 Best practices 92
🟢 SEO 100
🟠 PWA 89

Lighthouse ran on https://staging-academyv2.vercel.app/

@elPiablo
Copy link
Contributor

Just on a call with @rohann06 and in essence the PR is good to merge. However a new PR is needed because the images are taking too long to load since they are quite big/heavy.
cc @Markkos89

Copy link
Contributor

@elPiablo elPiablo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On a call with @rohann06 here and the images (too big/heavy) are loading to slowly, so a fresh PR is needed to solve that. But we can go ahead and merge this PR now.
cc @Markkos89

@elPiablo elPiablo merged commit 334669b into main Dec 17, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants