From 323ab3db67d5cff2c2d797bbcf971970fa5b1911 Mon Sep 17 00:00:00 2001 From: Sam Smith Date: Tue, 20 Jun 2023 22:09:54 -0400 Subject: [PATCH] Fix to bad situation when repo could be nuill --- src/DevOpsMetrics.Core/DataAccess/DORASummaryDA.cs | 2 +- .../Controllers/DORASummaryController.cs | 4 +--- .../Service/DORASummaryControllerTests.cs | 10 ++++------ 3 files changed, 6 insertions(+), 10 deletions(-) diff --git a/src/DevOpsMetrics.Core/DataAccess/DORASummaryDA.cs b/src/DevOpsMetrics.Core/DataAccess/DORASummaryDA.cs index 1c81cbff..a5e9a02e 100644 --- a/src/DevOpsMetrics.Core/DataAccess/DORASummaryDA.cs +++ b/src/DevOpsMetrics.Core/DataAccess/DORASummaryDA.cs @@ -27,7 +27,7 @@ public static async Task GetDORASummaryItem(TableStorageConfigu { foreach (DORASummaryItem item in doraItems) { - if ((project != null && item.Project == project) || (item.Repo.ToLower() == repo.ToLower())) + if ((project != null && item.Project == project) || (item.Repo?.ToLower() == repo.ToLower())) { result = item; break; diff --git a/src/DevOpsMetrics.Service/Controllers/DORASummaryController.cs b/src/DevOpsMetrics.Service/Controllers/DORASummaryController.cs index 50c44f95..e48995f7 100644 --- a/src/DevOpsMetrics.Service/Controllers/DORASummaryController.cs +++ b/src/DevOpsMetrics.Service/Controllers/DORASummaryController.cs @@ -6,10 +6,8 @@ using DevOpsMetrics.Core.DataAccess.TableStorage; using DevOpsMetrics.Core.Models.Common; using Microsoft.AspNetCore.Mvc; -using Microsoft.Build.Framework; using Microsoft.Extensions.Configuration; using Microsoft.Extensions.Logging; -using Microsoft.Extensions.Logging.Abstractions; namespace DevOpsMetrics.Service.Controllers { @@ -56,7 +54,7 @@ public async Task UpdateDORASummaryItem( Microsoft.Extensions.Logging.ILogger log = null, bool useCache = true, bool isGitHub = true, - bool useParallelProcessing = false) + bool useParallelProcessing = true) { //Start timer DateTime startTime = DateTime.Now; diff --git a/src/DevOpsMetrics.Tests/Service/DORASummaryControllerTests.cs b/src/DevOpsMetrics.Tests/Service/DORASummaryControllerTests.cs index e12c06b4..513012c2 100644 --- a/src/DevOpsMetrics.Tests/Service/DORASummaryControllerTests.cs +++ b/src/DevOpsMetrics.Tests/Service/DORASummaryControllerTests.cs @@ -1,14 +1,12 @@ using System; using System.Collections.Generic; using System.Diagnostics; -using System.Reflection; using System.Threading.Tasks; using DevOpsMetrics.Core.DataAccess.TableStorage; using DevOpsMetrics.Core.Models.AzureDevOps; using DevOpsMetrics.Core.Models.Common; using DevOpsMetrics.Core.Models.GitHub; using DevOpsMetrics.Service.Controllers; -using Microsoft.AspNetCore.Mvc; using Microsoft.VisualStudio.TestTools.UnitTesting; namespace DevOpsMetrics.Tests.Service @@ -40,10 +38,10 @@ public async Task DORASummaryControllerGitHubUpdateIntegrationTest() { //Arrange string project = null; - string organization = "DeveloperMetrics"; - string repo = "DevOpsMetrics"; - //string organization = "samsmithnz"; - //string repo = "Sams2048"; + //string organization = "DeveloperMetrics"; + //string repo = "DevOpsMetrics"; + string organization = "samsmithnz"; + string repo = "SamsFeatureFlags"; //string organization = "samsmithnz"; //string repo = "CustomQueue"; //string organization = "samsmithnz";