Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgraded pipelines #79

Merged
merged 2 commits into from
Nov 19, 2024
Merged

Upgraded pipelines #79

merged 2 commits into from
Nov 19, 2024

Conversation

ikrivosheev
Copy link
Contributor

This is first part of: #78

  • Upgraded version for plugins
  • Replaces use actions-rs to dtolnay/rust-toolchain

@ikrivosheev ikrivosheev mentioned this pull request Nov 19, 2024
Closed
jplatte
jplatte reviewed Nov 19, 2024
View reviewed changes
Cargo.toml Show resolved Hide resolved
@ikrivosheev ikrivosheev mentioned this pull request Nov 19, 2024
Merged
3 tasks
@ikrivosheev
Copy link
Contributor Author

@jplatte I fixed cargo sort

@jplatte
Copy link
Collaborator

jplatte commented Nov 19, 2024 •
edited
Loading

I don't like that. No idea what's making cargo sort complain about three separate comment lines one after the other, but.. let's just remove that step from CI?

cargo sort was really always meant for large projects with big Cargo.toml files, using it on itself is kind of nice as a way of dogfooding, but it wouldn't catch regressions since it installs from crates.io.

@ikrivosheev
Copy link
Contributor Author

I don't like that. No idea what's making cargo sort complain about three separate comment lines one after the other, but.. let's just remove that step from CI?

cargo sort was really always meant for large projects with big Cargo.toml files, using it on itself is kind of nice as a way of dogfooding, but it wouldn't catch regressions since it installs from crates.io.

Yes, I removed cargo sort from CI

@jplatte jplatte merged commit af0aa81 into DevinR528:main Nov 19, 2024
4 checks passed
@ikrivosheev ikrivosheev deleted the fix/upgrade_ci branch November 19, 2024 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jplatte jplatte jplatte approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ikrivosheev @jplatte