From ce4d59f9d9787a619bf0724e9eaa2c304f84ac34 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Beno=C3=AEt=20CORTIER?= <bcortier@proton.me>
Date: Fri, 18 Oct 2024 18:20:59 +0900
Subject: [PATCH] ci: fix pull_request check workflow for PRs coming from forks

---
 .github/workflows/ci.yml | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
index 80fd97d8..e0f1efa6 100644
--- a/.github/workflows/ci.yml
+++ b/.github/workflows/ci.yml
@@ -374,7 +374,7 @@ jobs:
     name: devolutions-gateway [${{ matrix.os }} ${{ matrix.arch }}]
     runs-on: ${{ matrix.runner }}
     needs: [preflight, devolutions-gateway-web-ui]
-    if: always()
+    if: always() # The webapp can’t be build without secrets that we don’t provide for PRs coming from forks.
     strategy:
       matrix:
         include: ${{ fromJson(needs.preflight.outputs.gateway-build-matrix) }}
@@ -508,6 +508,7 @@ jobs:
     name: devolutions gateway merge artifacts
     runs-on: ubuntu-latest
     needs: [preflight, devolutions-gateway]
+    if: always() # The job is skipped for PRs coming from forks because the devolutions-gateway job would have been skipped (if always() wasn’t used). Another GitHub action oddity.
 
     steps:
       - name: Merge Artifacts
@@ -521,7 +522,6 @@ jobs:
     name: devolutions-agent [${{ matrix.os }} ${{ matrix.arch }}]
     runs-on: ${{ matrix.runner }}
     needs: [preflight]
-    if: always()
     strategy:
       matrix:
         include: ${{ fromJson(needs.preflight.outputs.agent-build-matrix) }}
@@ -718,10 +718,11 @@ jobs:
   success:
     name: Success
     runs-on: ubuntu-latest
-    if: ${{ always() }}
+    if: always()
     needs:
       - tests
       - jetsocat-lipo
+      - devolutions-gateway
       - devolutions-gateway-merge
       - devolutions-agent-merge
       - dotnet-utils-tests